astro-informatics / purify

Next-generation radio interferometric imaging.
https://astro-informatics.github.io/purify
GNU General Public License v2.0
17 stars 13 forks source link

New MPI algorithm for next future release #256

Closed Luke-Pratley closed 5 years ago

Luke-Pratley commented 5 years ago

A new implementation of the MPI measurement operator that fixes issues with previous implementations by using an all to all operation.

codecov-io commented 5 years ago

Codecov Report

Merging #256 into development will increase coverage by 0.57%. The diff coverage is 92.07%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #256      +/-   ##
===============================================
+ Coverage        86.39%   86.97%   +0.57%     
===============================================
  Files               67       67              
  Lines             5294     5882     +588     
===============================================
+ Hits              4574     5116     +542     
- Misses             720      766      +46
Impacted Files Coverage Δ
cpp/purify/wide_field_utilities.cc 75% <ø> (ø) :arrow_up:
cpp/purify/mpi_utilities.h 100% <ø> (ø) :arrow_up:
cpp/purify/yaml-parser.h 100% <ø> (ø) :arrow_up:
cpp/purify/distribute.h 100% <ø> (ø) :arrow_up:
cpp/tests/kmeans.cc 100% <100%> (ø) :arrow_up:
cpp/tests/parser_test.cc 100% <100%> (ø) :arrow_up:
cpp/tests/operators.cc 100% <100%> (ø) :arrow_up:
cpp/purify/yaml-parser.cc 80.28% <100%> (+0.18%) :arrow_up:
cpp/purify/AllToAllSparseVector.h 100% <100%> (ø) :arrow_up:
cpp/purify/measurement_operator_factory.h 84% <71.42%> (-4.89%) :arrow_down:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 625c113...6195bf2. Read the comment docs.

Luke-Pratley commented 5 years ago

This should be ready to be merged. @dpshelio Can you approve this?

Luke-Pratley commented 5 years ago

@dpshelio @UCLGuichard Can we merge this? The code is now being used in the primal dual branch as well.