astro-informatics / purify

Next-generation radio interferometric imaging.
https://astro-informatics.github.io/purify
GNU General Public License v2.0
17 stars 13 forks source link

Primal dual #257

Closed Luke-Pratley closed 5 years ago

Luke-Pratley commented 5 years ago

This needs https://github.com/astro-informatics/sopt/pull/238 to be merged before it will work!

This update includes tests and the primal dual to the main.cc. It also adds this algorithm to the parser.

It also provides the correct flux values when doing image reconstruction.

It also has preconditioning. It also has the all to all wproj operator with a circular stop gap before the horizon for ultra wide-fields of view.

codecov-io commented 5 years ago

Codecov Report

Merging #257 into development will increase coverage by 0.06%. The diff coverage is 94.51%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #257      +/-   ##
===============================================
+ Coverage        86.39%   86.46%   +0.06%     
===============================================
  Files               67       66       -1     
  Lines             5294     6259     +965     
===============================================
+ Hits              4574     5412     +838     
- Misses             720      847     +127
Impacted Files Coverage Δ
cpp/purify/types.h 100% <ø> (ø) :arrow_up:
cpp/purify/mpi_utilities.h 100% <ø> (ø) :arrow_up:
cpp/purify/yaml-parser.h 100% <ø> (ø) :arrow_up:
cpp/purify/AllToAllSparseVector.cc 100% <ø> (ø) :arrow_up:
cpp/purify/operators.cc 97.43% <ø> (ø) :arrow_up:
cpp/purify/distribute.h 100% <ø> (ø) :arrow_up:
cpp/purify/utilities.h 100% <ø> (ø) :arrow_up:
cpp/purify/wide_field_utilities.cc 93.1% <100%> (+18.1%) :arrow_up:
cpp/tests/kmeans.cc 100% <100%> (ø) :arrow_up:
cpp/purify/convergence_factory.h 89.74% <100%> (-0.26%) :arrow_down:
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 625c113...a41718e. Read the comment docs.

Luke-Pratley commented 5 years ago

@dpshelio So this has tests passing and I don't want to make more changes because it is way too big. When the next test passes I want to merge.