search

astro-informatics / purify

Next-generation radio interferometric imaging.
https://astro-informatics.github.io/purify
GNU General Public License v2.0
17 stars 13 forks source link

RM Synthesis code that could be combined with imaging one day #262

Open Luke-Pratley opened 5 years ago

Luke-Pratley commented 5 years ago

RM measurement operator + example of 1d reconstruction + tests

codecov-io commented 5 years ago

Codecov Report

Merging #262 into development will increase coverage by 0.44%. The diff coverage is 93.29%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #262      +/-   ##
===============================================
+ Coverage        86.46%   86.91%   +0.44%     
===============================================
  Files               66       70       +4     
  Lines             6259     6602     +343     
===============================================
+ Hits              5412     5738     +326     
- Misses             847      864      +17
Impacted Files Coverage Δ
cpp/tests/rm_operator.cc 100% <100%> (ø)
cpp/purify/rm_kernel_integration.cc 100% <100%> (ø)
cpp/purify/rm_operators.cc 70% <70%> (ø)
cpp/purify/rm_operators.h 95.53% <95.53%> (ø)
cpp/purify/kernels.cc 61.17% <0%> (+3.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a732220...5f5189a. Read the comment docs.

Luke-Pratley commented 5 years ago

This is ready to merge!

CosmoMatt commented 2 years ago

hey @Luke-Pratley we're tidying up PR's for PURIFY, can you remember what the state of this PR is? It seems as though it's ready to go, provided a few conflicts?

Luke-Pratley commented 2 years ago

@CosmoMatt I think it is fine for it to be merged tbh. It is adjacent to the interferometric imaging, so I am not surprised it is mostly ready to be merged.