Use conan to install dependencies

astro-informatics / purify

Next-generation radio interferometric imaging.

https://astro-informatics.github.io/purify

GNU General Public License v2.0

17 stars 13 forks source link

Closed tkoskela closed 1 year ago

tkoskela commented 2 years ago

tkoskela commented 2 years ago

Following relative success of https://github.com/astro-informatics/sopt/issues/262, this is ready to proceed

SJaffa commented 2 years ago

[x] Create branch off development
[x] Check it compiles and builds
[x] Set up Conan to install packages that were installed by GreatCmakeCookoff lookup_packages
[x] See what breaks

SJaffa commented 2 years ago

The following commands run fine:

conan install ..
cmake -DCMAKE_BUILD_TYPE=Release ..
make

make test takes ages so I killed it, check another time.

But Actions are failing with the error: ‘stdout_logger_mt’ is not a member of ‘spdlog’ which we fixed before!?! Confused.

tkoskela commented 2 years ago

We fixed that in sopt and this is purify, right? I wonder if the same logging code has been copied into purify

SJaffa commented 2 years ago

This error is coming from sopt because Purify pulls the main branch. Once the fix is pulled into the main branch of sopt this should go away.