astro-informatics / purify

Next-generation radio interferometric imaging.
https://astro-informatics.github.io/purify
GNU General Public License v2.0
17 stars 13 forks source link

CI failing on Ubuntu because of ccache timestamp #316

Closed SJaffa closed 1 year ago

SJaffa commented 1 year ago

GitHub Actions are failing on Ubuntu in the prepare ccache timestamp step

Output:

Run echo "{date_and_time}={$(date +'%Y-%m-%d-%H;%M;%S')}" >> $GITHUB_OUTPUT
  echo "{date_and_time}={$(date +'%Y-%m-%d-%H;%M;%S')}" >> $GITHUB_OUTPUT
  shell: /usr/local/bin/cmake -P {0}
  env:
    BUILD_TYPE: Release
    OMP_NUM_THREADS: 2
    CONAN_PRINT_RUN_COMMANDS: 1
    CONAN_CPU_COUNT: 2
    CONAN_SKIP_BROKEN_SYMLINKS_CHECK: True
    CC: gcc-9
    CXX: g++-9
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.11/x64/lib:/usr/local/lib
    pythonLocation: /opt/hostedtoolcache/Python/3.10.11/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.11/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.11/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.11/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.11/x64
CMake Error at /home/runner/work/_temp/f09b53e7-0e9b-4d9e-9b8d-b4e905aba3dc:1:
  Parse error.  Expected "(", got quoted argument with text
  "{date_and_time}={$(date +'%Y-%m-%d-%H;%M;%S')}".

CMake Error: Error processing file: /home/runner/work/_temp/f09b53e7-0e9b-4d9e-9b8d-b4e905aba3dc
Error: Process completed with exit code 1.
tkoskela commented 1 year ago

The only difference I can see between sopt (where this works) and purify (where it doesn't) is that in purify we've got shell: cmake -P {0}.

tkoskela commented 1 year ago

Tested this and removing shell: cmake -P {0} seems to have fixed it. I'll open a PR once my tests finish