search

astro-informatics / purify

Next-generation radio interferometric imaging.
https://astro-informatics.github.io/purify
GNU General Public License v2.0
17 stars 13 forks source link

FFT operator on non-square images does not work #43

Closed Luke-Pratley closed 8 years ago

Luke-Pratley commented 8 years ago

The FFT operator gives a scrambled image when applied to a non-square image. The FFT operator does a 2d FFT with fftw3 through Eigen.

The old FFT operator, which is done through a series of 1d FFTs still works on non-square images, which suggests it could be related Eigen 2D FFT.

Luke-Pratley commented 8 years ago

We have found that the bug is related to conversion between RowMajor and ColMajor types before the data is put into FFTW. This can be fixed by swapping the indices for row and column. See https://github.com/astro-informatics/purify/commit/2ff5e7fe3300a2870cd326027be022568426dfcc.