Missing header files - Githubissues

astro-informatics / s2let

Fast wavelet transforms on the sphere.

http://astro-informatics.github.io/s2let

GNU General Public License v3.0

11 stars 2 forks source link

Missing header files #10

Closed paddyroddy closed 4 years ago

paddyroddy commented 4 years ago

When building the cmake on a recent upgrade of command line tools for mac it errored on missing header files

this PR merely imports so3_adjoint.h in two files and besides that it is IDE automatic formatting changes

auggiemarignier commented 4 years ago

This cause make to fail for me

However changing the ssht inclusions in the header files works

paddyroddy commented 4 years ago

This cause make to fail for me

However changing the ssht inclusions in the header files works

Your fix doesn't work for me

auggiemarignier commented 4 years ago

@paddyroddy I think I've found something. so3 has 2 so3.h files: one in include/c and another in src/c. The latter one doesn't include so3_adjoint.h but the former does. I suspect when you ran cmake for s2let the So3_INCLUDE_DIR was src/c. If you retry with include/c instead it should work. If it does then we'll have to fix so3 to have just the one header file.

Also we must be using slightly different compilers because your error is just a warning for me if I have src/c as the So3_INCLUDE_DIR

paddyroddy commented 4 years ago

@auggiemarignier yep you're right, well spotted

This is what I was running, but changing to include for SO3 works cmake .. -DSsht_INCLUDE_DIR=$SSHT/src/c/ -DSsht_LIBRARY=$SSHT/build/src/c/libssht.a -DSo3_INCLUDE_DIR=$SO3/src/c/ -DSo3_LIBRARY=$SO3/build/libso3.a -Dtests=OFF && make clean all

depending on which one we end up with we'll need to adjust setup.py too https://github.com/astro-informatics/src_s2let/blob/605fd8764df046e37889e4e3dad52c37334b447c/setup.py#L19

auggiemarignier commented 4 years ago

Awesome. We can make that change when the PR on so3 has been approved. In the mean time I'll close this PR