Missing sqrt factor

[paddyroddy]

from the s2let paper it looks like there is a sqrt missing

[jasonmcewen]

@paddyroddy It's possible the paper may not match precisely the definition used in the code. There is a choice in where to put this square root so it could be factored in elsewhere in the code. I would be very surprised if there is a missing square root factor since that would change the accuracy of the transforms. Have you checked that an inverse followed by forward transform still give machine precision accuracy with this change?

[paddyroddy]

I can't build the matlab so no

[paddyroddy]

either way the code isn't consistent with the construction of ridgelets/curvelets

[jasonmcewen]

Indeed, it could be different to what is done for ridgelets or curvelets. The key thing is that each type of wavelet is self consistent.

I think it unlikely this change is correct. The matlab version has worked correctly in the past. Changing a square root factor in one place would break that. So we would need to test this before seeing whether it is needed.

[paddyroddy]

I agree regarding testing but it means I'm unsure whether to put a sqrt in my code or not - I know it's just scaling but want to do it right

[jasonmcewen]

Let's move this discussion to Slack...

[paddyroddy]

Have verified that the sqrt is not there but having talked with @jasonmcewen this has been a choice of normalisation within the code so I'll close this PR

setting up mathematica

kappa0 mathematica

kappa mathematica

python results