search

astro-informatics / s2wav

Differentiable and accelerated wavelet transform on the sphere with JAX
https://astro-informatics.github.io/s2wav/
MIT License
13 stars 0 forks source link

Correcting typos in file name and a function name #26

Closed JessWhitney closed 1 year ago

JessWhitney commented 1 year ago

One of the functions had a typo in its definition. Updating that so no errors arise when calling upon the function later on.

JessWhitney commented 1 year ago

@alicjapolanska also mentioned my j_max function wasn't working. I think it's because I wasn't calling math.log. Fixed that now, let me know if it continues to give an error!

JessWhitney commented 1 year ago

@CosmoMatt If you're happy with the second change too, I'll merge the PR.

CosmoMatt commented 1 year ago

@JessWhitney math.log is one approach, could also use np.log which might be more consistent going forward. Otherwise, as far as I can tell, looks fine.

JessWhitney commented 1 year ago

@JessWhitney math.log is one approach, could also use np.log which might be more consistent going forward. Otherwise, as far as I can tell, looks fine.

Can the same be done for math.ceil -> np.ceil ?

CosmoMatt commented 1 year ago

Technically yes but perhaps you're right, if we're already using math.ceil at this level maybe just stick with math.log -- in which case this should be fine to merge whenever you like @JessWhitney

JessWhitney commented 1 year ago

Alright I'll stick with the math module for now, we can always amend this later on.