search

astro-informatics / s2wav

Differentiable and accelerated wavelet transform on the sphere with JAX
https://astro-informatics.github.io/s2wav/
MIT License
12 stars 0 forks source link

Vectorising Analysis Transform #48

Closed JessWhitney closed 1 year ago

JessWhitney commented 1 year ago

This PR adds an alternative version of the analysis transform function which is vectorised, and adds an associated test for it in the test logs. Code for issue #39 .

codecov-commenter commented 1 year ago

Codecov Report

Base: 74.49% // Head: 75.77% // Increases project coverage by +1.28% :tada:

Coverage data is based on head (2df95ef) compared to base (f40cb69). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================== + Coverage 74.49% 75.77% +1.28% ========================================== Files 9 9 Lines 396 417 +21 ========================================== + Hits 295 316 +21 Misses 101 101 ``` | [Impacted Files](https://codecov.io/gh/astro-informatics/s2wav/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics) | Coverage Δ | | |---|---|---| | [s2wav/analysis.py](https://codecov.io/gh/astro-informatics/s2wav/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics#diff-czJ3YXYvYW5hbHlzaXMucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

CosmoMatt commented 1 year ago

@JessWhitney looks great and passes tests (both on GH actions and locally). Just removed the wavelet generators from the analysis tests (as they weren't needed/being used) but other than that should be ready to merge!