search

astro-informatics / s2wav

Differentiable and accelerated wavelet transform on the sphere with JAX
https://astro-informatics.github.io/s2wav/
MIT License
12 stars 0 forks source link

JAX Wavelet Transforms #59

Closed CosmoMatt closed 1 year ago

CosmoMatt commented 1 year ago

@JessWhitney implemented the synthesis transform in JAX, and it is passing regression tests against s2let. There are some things we should do to accelerate this transform but for the time being we can merge this as is :)

codecov-commenter commented 1 year ago

Codecov Report

Base: 94.62% // Head: 95.05% // Increases project coverage by +0.43% :tada:

Coverage data is based on head (d0abec6) compared to base (0217bea). Patch coverage: 98.36% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== + Coverage 94.62% 95.05% +0.43% ========================================== Files 7 7 Lines 279 344 +65 ========================================== + Hits 264 327 +63 - Misses 15 17 +2 ``` | [Impacted Files](https://codecov.io/gh/astro-informatics/s2wav/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics) | Coverage Δ | | |---|---|---| | [s2wav/utils/shapes.py](https://codecov.io/gh/astro-informatics/s2wav/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics#diff-czJ3YXYvdXRpbHMvc2hhcGVzLnB5) | `97.50% <91.30%> (-2.50%)` | :arrow_down: | | [s2wav/transforms/jax\_wavelets.py](https://codecov.io/gh/astro-informatics/s2wav/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics#diff-czJ3YXYvdHJhbnNmb3Jtcy9qYXhfd2F2ZWxldHMucHk=) | `100.00% <100.00%> (ø)` | | | [s2wav/transforms/numpy\_wavelets.py](https://codecov.io/gh/astro-informatics/s2wav/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics#diff-czJ3YXYvdHJhbnNmb3Jtcy9udW1weV93YXZlbGV0cy5weQ==) | `98.91% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-informatics)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

JessWhitney commented 1 year ago

Were the tests failing previously because we had Jmin > Jmax? @CosmoMatt

CosmoMatt commented 1 year ago

Were the tests failing previously because we had Jmin > Jmax? @CosmoMatt

So when I updated J_min to be 1 for the testing cases, I forgot to add a flag that skipped the test if J_min was > J in the other tests, like you say :)