astro-informatics / s2wav

Differentiable and accelerated wavelet transform on the sphere with JAX
https://astro-informatics.github.io/s2wav/
MIT License
12 stars 0 forks source link

Housekeeping/clean code up #78

Closed CosmoMatt closed 2 months ago

CosmoMatt commented 4 months ago

Scope crept quite a lot on this but still effectively housekeeping. Main contributions:

Housekeeping

Added features

C backend support for SSHT operations

CI related

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 91.53005% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 91.99%. Comparing base (c5702aa) to head (6394602).

Files Patch % Lines
s2wav/filters.py 88.10% 22 Missing :warning:
s2wav/transforms/wavelet_precompute_torch.py 92.30% 4 Missing :warning:
s2wav/samples.py 91.66% 2 Missing :warning:
s2wav/transforms/wavelet.py 93.93% 2 Missing :warning:
s2wav/transforms/construct.py 96.77% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================== + Coverage 88.31% 91.99% +3.67% ========================================== Files 8 7 -1 Lines 522 587 +65 ========================================== + Hits 461 540 +79 + Misses 61 47 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CosmoMatt commented 3 months ago

@jasonmcewen I'm not sure I follow. What notebook links do you mean?

jasonmcewen commented 3 months ago

@CosmoMatt There appear to be nblink files in the repo? Remember we chances how the notebooks were set up for colab support in s2fft?