search

astro-informatics / sopt

Sparse OPTimisation using state-of-the-art convex optimisation algorithms.
http://astro-informatics.github.io/sopt/
GNU General Public License v2.0
8 stars 10 forks source link

Add MPI communicators to g_proximal class #357

Closed tkoskela closed 1 week ago

tkoskela commented 1 year ago

MPI communicators adjoint_space_comm and direct_space_comm in imaging_forward_backward.h were removed during the refactor in #303. These should go back in, because they are needed by https://github.com/astro-informatics/sopt/blob/ae4c48e397b99d6b27b727744da292cb3f1817ce/cpp/sopt/l1_proximal.h#L151-L156.

If the l1_proximal class is the only class that uses them, we can make them members of the l1_g_proximal class and set them during initialisation in purify, we don't need a pulblic interface in the parent g_proximal class.

tkoskela commented 1 week ago

Closed by https://github.com/astro-informatics/purify/pull/315