Modernise: For type template parameters, replaces the old keyword 'class' with 'typename'

astro-informatics / sopt

Sparse OPTimisation using state-of-the-art convex optimisation algorithms.

http://astro-informatics.github.io/sopt/

GNU General Public License v2.0

9 stars 11 forks source link

Modernise: For type template parameters, replaces the old keyword 'class' with 'typename' #410

Closed krishnakumarg1984 closed 1 year ago

krishnakumarg1984 commented 1 year ago

Although there is no technical difference between class and typename for type template parameters, we may argue that typename better conveys its semantic meaning.

To many people's chagrin, class is a much overloaded keyword. When using the keyword class, are we referring to a custom class or simply a placeholder for a templated type? Clearly, typename has better semantics in my opinion.

mmcleod89 commented 1 year ago

Does anyone have strong feelings about this? I personally have no real issue either way; I tend to use typename in my own code, but class and typename are identical in this context.