incorrect rotation direction in rotate image

astro-informatics / ssht

Fast and exact spin spherical harmonic transforms

http://astro-informatics.github.io/ssht/

GNU General Public License v3.0

11 stars 2 forks source link

incorrect rotation direction in rotate image #45

Closed mdavezac closed 3 years ago

mdavezac commented 3 years ago

rotate_flm should be consistent with rotate_image: add test
this line ought to rotate by -gamma, -beta, -alpha

jasonmcewen commented 3 years ago

@mdavezac On a quick look this change does not look correct. We should be changing the rotation (alpha,beta,gamma) to (-gamma,-beta,-alpha) but it simply looks like the sign of the cartesian coordinates have been changed?

Did you check the change makes rotate_image consistent with rotate_flm (as dicussed in the comment above)?