astro-pi / beta-testing

Bug tracker for the Trinket Sense HAT emulator
https://trinket.io/sense-hat
3 stars 0 forks source link

Error message off screen, seemingly no feedback #20

Closed bennuttall closed 8 years ago

bennuttall commented 8 years ago

On my laptop (1600x900 resolution), the error message is shown off screen, and there's no indication that an error has occurred:

screenshot from 2016-07-20 14-45-43

Scrolled down:

screenshot from 2016-07-20 14-45-50

If the error could pop up or the editor went red, or the error line was highlighted, anything that would indicate there's an issue would be really helpful.

eah13 commented 8 years ago

Thanks for this! Working on making the errors more visible via an indicator in the file tab that has the error. Also, in the example you gave a bug was preventing that import statement from being highlighted in red like a normal error, and that'll be fixed next deploy. Between the two there should be a lot more going on above the fold. We also likely should make the demo iframe a little smaller so more of it is visible on more screens.

eah13 commented 8 years ago

@bennuttall thanks again for finding this. This is now fixed! There is a Red icon in the tab of the error and the line is highlighted.

screenshot 2016-07-25 at 1 21 22 pm

In Epiphany and other browsers where we've disabled Ace, the line number of the error will turn red.

Closing as fixed, but feel free to drop further feedback here.

davidhoness commented 8 years ago

I've discovered that this still happens if the error is not caused by bad syntax, for example an incorrect parameter type:

from sense_hat import SenseHat
sense = SenseHat()
sense.set_rotation(75)
eah13 commented 8 years ago

Nice find. Looking into this.

eah13 commented 8 years ago

@davidhoness Fixed! Thanks again for finding this. screenshot 2016-08-02 at 9 57 13 am