astro / microvm.nix

NixOS MicroVMs
https://astro.github.io/microvm.nix/
MIT License
1.25k stars 94 forks source link

Change microvm.host.enable to be false by default #180

Closed SuperSandro2000 closed 8 months ago

SuperSandro2000 commented 8 months ago

Just importing a module shouldn't change things. This likely requires other changes.

astro commented 8 months ago

As the host module is to be imported implicitly, this would break things for many users.

I am aware of the troubles with conditional module imports. I'm open for this if there's a compelling reason.

SuperSandro2000 commented 8 months ago

I did this because I explicitly needed to disable the module when building an iso where it isn't useful and just takes up space, which was quite unexpected

https://gitea.c3d2.de/c3d2/nix-config/src/commit/e9a4c3de115b57fd8188d659c6c047be3cde9967/modules/microvm-host.nix#L26

astro commented 8 months ago

On the other hand, the host module won't get in the way but provides the microvm command.