search

astro / nix-openwrt-imagebuilder

Build OpenWRT images in Nix derivations
MIT License
129 stars 16 forks source link

Build UCI configuration from an attrset #4

Closed ehmry closed 1 year ago

ehmry commented 2 years ago

Make UCI clean and declarative.

I should have documented that the extraFiles argument replaces files.

astro commented 2 years ago

Neat. Would it be appropriate to not rename files to extraFiles so that we don't break API?

I'd like to point out that there is more to be done to UCI, for example deleting default configuration.

ehmry commented 2 years ago

I'd like to recreate a subset of environment.etc.<…> from nixos, so files would be consistent but I made it extraFiles to make evaulation break on old configs.

I don't understand UCI so don't take this seriously yet.