astro / nix-openwrt-imagebuilder

Build OpenWRT images in Nix derivations
MIT License
129 stars 16 forks source link

builder: copy files to avoid making etc read-only #7

Closed tomjnixon closed 2 years ago

tomjnixon commented 2 years ago

This caused lines like this to appear in the logs:

.../sed: couldn't open temporary file .../etc/sed6fJsn9: Permission denied

These errors caused some changes to /etc/group to be missed.

A similar change could probably be made to copy packages rather than link them to get rid of the copy_file: unable to preserve ownership of ... messages from opkg, but I doubt that those actually cause issues, and that would only really make sense with #6.

astro commented 2 years ago

Nice, thank you very much!