astro / nix-openwrt-imagebuilder

Build OpenWRT images in Nix derivations
MIT License
129 stars 16 forks source link

Simplify hash generation #8

Closed tomjnixon closed 2 years ago

tomjnixon commented 2 years ago

Thanks for merging my other PRs!

This one changes the hash generation to not use the openwrt source flake input; there's a json file with the list of targets on the openwrt downloads site that can be used instead.

My motivation here is to make it easier update the hashes -- currently if the openwrt source input isn't updated to match the version being hashed then some targets/subtargets will go missing -- see for example realtek which was split up between 21.02.3 and 22.03.0, so is missing in the current 21.02.3 hashes.

It might be nice to just move this to a plain shell script (with a nix wrapper)?

astro commented 2 years ago

Awesome improvement!