search

astro / socksify-ruby

Redirect any TCP connection initiated by a Ruby script through a SOCKS5 proxy
http://socksify.rubyforge.org/
Other
165 stars 80 forks source link

Add authentication support to Net::HTTP.SOCKSProxy #24

Open ojab opened 9 years ago

astro commented 9 years ago

Cool, thank you. Please ping the new maintainer @musybite if nothing happens for a few days.

ojab commented 9 years ago

ping @musybite

musybite commented 8 years ago

Thank you for pull request @ojab and sorry for long silence. Everything looks good to me. I'll make release this weekend.

ojab commented 8 years ago

Thanks!

ojab commented 8 years ago

I've rebased PR #22 on current master (1.7.0) and put patch for this PR on top, please let me know if something should be changed.

mikecmpbll commented 8 years ago

@musybite I wonder if this will be merged & released?

ajimix commented 7 years ago

@musybite @astro any way that this can be merged? thanks!

musybite commented 6 years ago

@ojab @ajimix @mikecmpbll i'd proposed another implementation in MR #33. API is fully the same. Could you check whether it works for you?

I have certain doubts about switching from class @@-variables to thread-local variables: for example, it will definitely break socksify_ruby script for multi-threaded apps, and could lead to other unintended consequences. From the very beginning, socksify implied "global socksification" of whole application with all its threads, and thread-safe (albeit somewhat ugly) APIs were added only recently. For such old and stable project as socksify, it is important not to break compatibility.

ojab commented 6 years ago

I don't use socksify any more, so unfortunately I can't test this change.