search

astro4dev / OAD-Data-Science-Toolkit

The Office of Astronomy for Development's Data Science Toolkit.
https://datascience.astro4dev.org
GNU General Public License v3.0
20 stars 21 forks source link

Minor quality patches #46

Closed brucellino closed 7 years ago

brucellino commented 7 years ago

Hi @astro4dev !

I'd like to propose a few minor patches, mainly aimed at fixing typos. I have added a skeleton for Travis, which doesn't do anything yet, but can be used to test the jupyter notebooks.

The rest is just cleaning up the text.

paultheastronomer commented 7 years ago

Thank you for those changes. Is it bad practice to have links open a new tab? I see you changed the markdown of the links.

brucellino commented 7 years ago

Hi @paultheastronomer

I suggested the change to keep the text in markdown, and mix minimally with html... of course, html is totally valid markdown. I actually didn't consider whether the links opening in a new tab would change... this is only supported in html and kramdown, from what I can gather.

Seems I was a bit gung-ho on that ! Feel free to revert.

FWIW, before accepting the pull request, you could "protect" the branch and force a code review - find this in the repo settings. Also see https://help.github.com/articles/about-pull-request-reviews/

paultheastronomer commented 7 years ago

Noted. thanks!