search

astroash / dickhub

🍆 🥒 🥕 🌶
9 stars 0 forks source link

[WIP] Anonymise and setup user #12

Closed astroash closed 6 years ago

astroash commented 6 years ago

relates #4

ameliejyc commented 6 years ago

Oh hello. This is unrelated but given you're doing stuff, can we add in eslint-config-prettier to use prettier's formatting rather than eslint's craziness?

Also my prettier config is no trailing commas and single quotes.

astroash commented 6 years ago

we could write our own eslint config? Or pick something less opinionated than airbnb? I've messed around with my prettier settings loads, it seems silly for us both to manually set them the same.

ameliejyc commented 6 years ago

We don't even have prettier installed on this project actually, lol.

Hmm we can do eslint config if you like, tbh I like airbnb's opinionatedness tho.

astroash commented 6 years ago

Can you install prettier? I think it’s an editor thing and it just uses your eslint config file. If we’re both using vs code we could put our prettier setting in the workstation config and it will overwrite our user settings.

astroash commented 6 years ago

This PR could start to get quite big (and I'm making some structural changes). Feel free to merge if you wanna work on stuff.

ameliejyc commented 6 years ago

It's not just an editor thing - you can install prettier to the project and set the config. We should just sort it out in person when we next see each other! I might take a look at this pr this weekend but tbh pretty busy so no promises :(