search

astroband / ruby-stellar-base

The stellar-base library is the lowest-level stellar helper library. It consists of classes to read, write, hash, and sign the xdr structures that are used in stellar-core
Apache License 2.0
21 stars 19 forks source link

Stellar 0.6 support #28

Closed nullstyle closed 7 years ago

nullstyle commented 7 years ago

This PR adds basic support for stellar 0.6, updating the XDR definitions and resolving test failures that were introduced.

Notably, a very subtle bug was fixed around the autoloading of the generated XDR constants. Take note of the change to how we load the VERSION constant in the gemspec file. I leave these notes here for history:

The symptoms: Stellar::Asset was missing many class methods that caused load errors The issue: require_paths was not being obeyed. lib was being included into the $LOAD_PATH before generated. The solution: don't manually modify the $LOAD_PATH in the gemspec

nullstyle commented 7 years ago

Note: this PR unfortunately removes jruby from the CI suite. We don't have the resources to properly support it for now, but if someone else would like to help us, I'd be happy to coordinate contributions to re-enable jruby testing.