search

astroband / ruby-stellar-base

The stellar-base library is the lowest-level stellar helper library. It consists of classes to read, write, hash, and sign the xdr structures that are used in stellar-core
Apache License 2.0
21 stars 19 forks source link

Bring stellar up to date with Bloom's version #50

Closed ramontayag closed 5 years ago

ramontayag commented 5 years ago

https://github.com/stellar/ruby-stellar-sdk/issues/55#issuecomment-488121412

nebolsin commented 5 years ago

Please take a look at https://github.com/stellar/ruby-stellar-base/pull/49, it includes mostly the same set of changes, although fixes a change log (rbnacl switch happened in 0.18.0) and a few warnings in the test suite in Ruby 2.6.

ramontayag commented 5 years ago

Ok, will do so after this series of merges!

Ramon Tayag

On Tue, May 7, 2019 at 11:13 AM Sergey Nebolsin notifications@github.com wrote:

Please take a look at #49 https://github.com/stellar/ruby-stellar-base/pull/49, it includes mostly the same set of changes, although fixes a change log (rbnacl switch happened in 0.18.0) and a few warnings in the test suite in Ruby 2.6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stellar/ruby-stellar-base/pull/50#issuecomment-489891105, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAGF5GMTSQNAK6DDQYQLKDPUDXVPANCNFSM4HLE5MDA .

tomquisel commented 5 years ago

@ramontayag @nebolsin I'll merge in this PR (#50), and then once the repo is transferred @ramontayag can handle merging in #49 's improvements.