search

astroband / ruby-stellar-base

The stellar-base library is the lowest-level stellar helper library. It consists of classes to read, write, hash, and sign the xdr structures that are used in stellar-core
Apache License 2.0
21 stars 19 forks source link

Support stellar-core protocol 12 #51

Closed abuiles closed 5 years ago

ire-and-curses commented 5 years ago

@ramontayag to keep the SDK functioning, this PR is needed in advance of the protocol 12 update on October 28. We also need it merged and released ASAP to support stellar core commander for Horizon testing.

abuiles commented 5 years ago

Because of the name changes of some things this is technically a breaking change for anyone who is explicitly using or testing against those type names. I'm guessing given that much of the code where the changes occur are generates there's nothing we can do about that?

That's right. I think the assumption is that people wouldn't be relying on those ones, but if they do, then they'll have to change their code.

ramontayag commented 5 years ago

Because of the name changes of some things this is technically a breaking change for anyone who is explicitly using or testing against those type names. I'm guessing given that much of the code where the changes occur are generates there's nothing we can do about that?

That's right. I think the assumption is that people wouldn't be relying on those ones, but if they do, then they'll have to change their code.

This gem has been in 0.x for the longest time, but I've been thinking of releasing a 1.x since people use this in production. We can follow semver.

abuiles commented 5 years ago

@ramontayag I'm actually okay doing this release as 0.x and then cutting 1.X once we fully remote the path_payment function, since today it will behave in a backwards compatible manner.

ramontayag commented 5 years ago

Fair point! Will merge and release :+1: