Closed lzkelley closed 8 years ago
Will test with Supernovae later today. Also it seems like this is breaking Python 3.4, but the reason isn't entirely clear to me looking at the travis test (one of the imports failed).
How should the calls change from the old way to the new way? Let's use the ASASSN task as an example: https://github.com/astrocatalogs/supernovae/blob/master/tasks/asassn.py#L14-L17
Ah looks like 3.4 failing was a Travis goof (looks like some technical issue on their end for builds yesterday).
This pull-request contains enhancements for the way in which URLs are downloaded and cached, in addition to how
archived
mode operates. The existing methodsCatalog.load_cached_url
andTask.load_archive
provided some of the framework necessary for the overall caching/archiving/updating functionality --- but this was somewhat incomplete, and the additional pieces were put together in the individual tasks that needed them.Additionally, there was previously an error in the archived-mode logic which made normal imports run in the same way as archived mode.
The new machinery should consolidate everything cleanly.
_BEFORE_ this is merged:
Catalog.load_cached_url
andTask.load_archive
for backwards compatibility (e.g. withSupernovae
catalog).origin/master