astrocatalogs / faststars

MIT License
2 stars 0 forks source link

Added functionality for querying dustmaps and SDSS #2

Closed DouglasBoubert closed 6 years ago

DouglasBoubert commented 6 years ago

Requires the dustmaps python package (obtainable via 'pip install dustmaps').

guillochon commented 6 years ago

This seems to work fine, however I get a bunch of warnings out of the Gaia task that look like this:

WARNING: W27: None:3:0: W27: COOSYS deprecated in VOTable 1.2 [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - W27: None:3:0: W27: COOSYS deprecated in VOTable 1.2
WARNING: W35: None:5:0: W35: 'value' attribute required for INFO elements [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - W35: None:5:0: W35: 'value' attribute required for INFO elements
WARNING: W35: None:6:0: W35: 'value' attribute required for INFO elements [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - W35: None:6:0: W35: 'value' attribute required for INFO elements
WARNING: W35: None:7:0: W35: 'value' attribute required for INFO elements [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - W35: None:7:0: W35: 'value' attribute required for INFO elements
WARNING: W35: None:8:0: W35: 'value' attribute required for INFO elements [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - W35: None:8:0: W35: 'value' attribute required for INFO elements
WARNING: W35: None:9:0: W35: 'value' attribute required for INFO elements [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - W35: None:9:0: W35: 'value' attribute required for INFO elements
WARNING: W35: None:10:0: W35: 'value' attribute required for INFO elements [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - W35: None:10:0: W35: 'value' attribute required for INFO elements
WARNING: W06: None:13:0: W06: Invalid UCD 'meta.id;meta.version': Primary word 'meta.version' is not valid as a secondary word [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W06: None:13:0: W06: Invalid UCD 'meta.id;meta.version': Primary word 'meta.version' is not valid as a secondary word
WARNING: W50: None:76:0: W50: Invalid unit string 'Time[Julian Years]' [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:76:0: W50: Invalid unit string 'Time[Julian Years]'
WARNING: W50: None:84:0: W50: Invalid unit string 'Angle[mas]' [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:84:0: W50: Invalid unit string 'Angle[mas]'
WARNING: W50: None:92:0: W50: Invalid unit string 'Angle[mas]' [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:92:0: W50: Invalid unit string 'Angle[mas]'
WARNING: W50: None:96:0: W50: Invalid unit string 'Angle[mas]' [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:96:0: W50: Invalid unit string 'Angle[mas]'
WARNING: W50: None:100:0: W50: Invalid unit string 'Angle[mas]' [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:100:0: W50: Invalid unit string 'Angle[mas]'
WARNING: W50: None:122:0: W50: Invalid unit string 'Dimensionless[see description]' [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:122:0: W50: Invalid unit string 'Dimensionless[see description]'
WARNING: W50: None:126:0: W50: Invalid unit string 'Dimensionless[see description]' [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:126:0: W50: Invalid unit string 'Dimensionless[see description]'
WARNING: W50: None:130:0: W50: Invalid unit string 'Dimensionless[see description]' [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:130:0: W50: Invalid unit string 'Dimensionless[see description]'
WARNING: W50: None:134:0: W50: Invalid unit string 'Dimensionless[see description]' [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:134:0: W50: Invalid unit string 'Dimensionless[see description]'
WARNING: W50: None:138:0: W50: Invalid unit string 'Dimensionless[see description]' (suppressing further warnings of this type...) [astropy.io.votable.tree]
 - - - - - - - - - - - - - - - - - - - - - - - - - - - W50: None:138:0: W50: Invalid unit string 'Dimensionless[see description]' (suppressing further warnings of this type...)

I have everything updated to the latest releases on pip. Just thought I'd mention in case the warnings indicate we're doing something we should be.

DouglasBoubert commented 6 years ago

I got those messages too, but didn't have a chance to investigate further. I believe it is probably an error in astroquery.gaia. Could you ask on their slack?

guillochon commented 6 years ago

None of the people on their slack actually had developed that module, so I'm not sure that they'd know.

P.S. the output of this PR is now visible on the page, although I didn't utilize some of the new columns yet.

On Wed, Mar 28, 2018 at 11:40 AM, Douglas Boubert notifications@github.com wrote:

I got those messages too, but didn't have a chance to investigate further. I believe it is probably an error in astroquery.gaia. Could you ask on their slack?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/astrocatalogs/faststars/pull/2#issuecomment-376933338, or mute the thread https://github.com/notifications/unsubscribe-auth/AExDqsLaj8b1GR_S-X5KNVlUwvVPP5Ipks5ti67xgaJpZM4S9sbg .

-- James Guillochon ITC Fellow at the Harvard-Smithsonian CfA jguillochon@cfa.harvard.edu

DouglasBoubert commented 6 years ago

Hmm... I'll email the author of that module!