Analysis tutorial

[adampbeardsley]

github won't let me comment line-by-line on the notebook. So here we go:

• [ ] I've simplified some of the imports.
• [ ] There's a speed_of_light variable and a c variable (which oddly don't agree). We should just have one, and ideally use scipy.constants rather than hard coding.
• [ ] The functions f2v() and doppler() appear redundant but slightly different. I tried to resolve this, but I'm a bit confused.
• [ ] In the LSR_shift() function, I'm not sure how the loc = line and the first location = line differ. I see the from_geodetic part, but in practice it seems to do exactly the same thing.
• [ ] There's an astropy deprecation warning in this cell when transforming a frame instance to a frame class. I haven't dug into that yet.
• [ ] What's the significance of "45deg" in the variable name pointing_45deg?
• [ ] The function find_array_with_number could use a short description
• [ ] Cleaned up the interactive plot function
• [ ] I started to clean up goodness_of_fit, but got a little lost because there are a bunch of calculations made that weren't used. I think my version does what was intended... maybe?
• [ ] Is goodness_of_fit used anyway?
• [ ] The several paragraphs just before reading in data needs to be reworked. There's stuff out of order, and it's repetitive. And some mistakes (e.g. you can't call a variable 21cm in python - variables cannot start with a number. I'll take a pass later, but this is as far as I got today.

[adampbeardsley]

I ended up doing a major reorganization of the tutorial to detangle some of the steps. @lmberkhout let me know what you think. A couple outstanding issues:

• [x] Plots are huge. Need to go back and resize everything
• [x] I can't get the interactive plots to work on my end. They respond exactly once to a change to the sliders. (nevermind... it works on the winona server... must be my local environment that's the problem)
• [ ] Need someone to double check the tangent point math. I rewrote some to harmonize variables.
• [ ] We should probably address some of the many astropy warnings. But I suppose we can merge and come back to that later.

[adampbeardsley]

Ok @lmberkhout I think it's ready for a final pass on your end. If you're happy we can merge.