Bug with only two sets of science data determining dither pattern for mmirs_pipeline_taskfile

astrochun / MMTtools

A set of Python 2.7 and 3.x codes to use with data from MMT

https://astrochun.github.io/project/mmttools/mmirs/

MIT License

0 stars 5 forks source link

Bug with only two sets of science data determining dither pattern for mmirs_pipeline_taskfile #14

Closed astrochun closed 6 years ago

astrochun commented 6 years ago

Bug was found with Jan-Torge Schindler when working with only two dithered science exposure.

This is because get_diff_images() is looking for a third exposure to determine if dither pattern is ABBA, ABAB, or ABApBp. I've added a fix to this in commit 9b82d62.

However, I should make improvements to avoid it crashing further.

astrochun commented 6 years ago

Further improvement made in 073328f (previous fix was not complete and would have caused it to crash in a specific if statement. This bug should be fixed.