search

astrochun / Metallicity_Stack_Commons

Set of common codes used in metallicity studies that use stacking techniques
MIT License
0 stars 1 forks source link

Bug: metallicity_calculation call incorrect for composite_indv_detect module #41

Closed astrochun closed 4 years ago

astrochun commented 4 years ago

analysis.composite_indv_detect calls temp_metallicity_calc.metallicity_calculation incorrectly as the revised version in v0.6.0 now returns a single dictionary. However, there is odd handling of det3 for filling in information. To fix the latter, I changed temp_metallicity_calc.metallicity_calculation to allow for an option det3 index array input.

I've implemented the fix in [hotfix/v0.6.2](https://github.com/astrochun/Metallicity_Stack_Commons/tree/hotfix/0.6.2)

astrochun commented 4 years ago

Tested by @cmccormick1. Appears to work as expected.