astroconda / astroconda-contrib

Community Submitted Conda Recipes
12 stars 38 forks source link

New PyRAF 2.2.1 release, supporting Python 3 #762

Open jehturner opened 2 years ago

jehturner commented 2 years ago

Hello. You probably don't know me, since @jhunkeler & Matt Rendina have moved onto other things, but I'm James, the (occasional) Astroconda contributor and IRAF repo maintainer at Gemini (and before that collaborator on Ureka).

Since STScI officially transferred PyRAF to the "IRAF community" (https://github.com/iraf-community/pyraf/issues/60, https://github.com/iraf-community/pyraf/issues/70), Ole Streicher and I have been working to improve its compatibility with Python 3, resulting in a new release 2.2.1 a few days ago, which finally passes all of our testing with Gemini IRAF on Python 3. All releases prior to this one worked more reliably and (before 2.2.0) faster under Python 2, which is the reason (along with STSDAS containing a few Python 2 scripts) that IRAF users were advised to stick to Python 2 at https://astroconda.readthedocs.io/en/latest/installation.html#iraf-install.

This PR updates the Astroconda recipe with the new URL, version & dependencies and gets rid of the no-longer-needed 2to3 conversion. I'm not sure whether you still want to provide new pyraf builds in the main Astroconda channel, since STScI has stopped supporting IRAF (?), but Gemini has been depending on those and I don't want to assume that we should move the package(s) downstream without checking with you first. I think some of STScI's users would also find it useful :wink:. Note that this version is only for Python 3, while the Python 2 build can remain at 2.1.15.

The existing recipe's dependency list includes astropy, which pyraf only uses for running its self-tests, and ipython & matplotlib, which are optional at run-time. I don't know whether you have any opinion on keeping those as hard dependencies, but the last 2 are probably useful to pull in, since users might not know to install them separately and are likely to have them anyway. Another couple of dependencies have been removed (after a bit of discussion here and here) and a couple of general ones added.

Let me know whether you're going to make some builds for this (we specifically need py37 and ideally later versions too) and if not, I'll host them in a Gemini conda channel instead. Thanks!

jehturner commented 2 years ago

More details at https://github.com/iraf-community/pyraf/releases/tag/v2.2.1.

jehturner commented 2 years ago

Hi @BGannon2. Any thoughts on this? I suppose we'll just host PyRAF in Gemini's downstream conda channel and start wider staff testing if there's no news in the next week or so, but it would be good to confirm where we stand with updating IRAF & PyRAF packages generally. Thanks! James.