Expand tests - Githubissues

astrodbtoolkit / astrodb-template-db

A template for astronomical databases.

BSD 3-Clause "New" or "Revised" License

1 stars 2 forks source link

Closed kelle closed 5 months ago

kelle commented 1 year ago

Even though it's early still, I think it's time to start making some tests!

kelle commented 10 months ago

arjunsavel commented 10 months ago

Thinking about: every table should have a test.

Every table should have 1-2 entries. There will be things to test.

Try to avoid duplicating tests that are already enforced in the schema?

Do coordinates make sense?

Duplication? Unused-edness? Missingness? Validity?

Every source needs a name?

Empty strings?

Query simbad — aliases?

Magnitudes make sense?

For columns with "adopted" — only one adopted?

kelle commented 7 months ago

create the test database fixture in a conftest.py file.
make one test file per table? test_sources, etc.
I think the easiest tests are just are the number of things what we expect. E.g., 5 sources, 3 sources with ref 1, 2 sources with ref 2, etc. These are tests which should fail when data is added to the database. Forces folks to update tests for every ingest.

arjunsavel commented 6 months ago

Now testing that strings are validated (#32)!

arjunsavel commented 5 months ago

Split this up into multiple issues (#46, #47, #48, #49, #50, #51, #52, #53, #54)