make conftest.py for data integrity testing

astrodbtoolkit / astrodb-template-db

A template for astronomical databases.

https://astrodb-template-db.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

1 stars 2 forks source link

make conftest.py for data integrity testing #55

Closed arjunsavel closed 5 months ago

arjunsavel commented 5 months ago

Addresses #53.

dr-rodriguez commented 5 months ago

To demonstrate this PR works, you should remove the duplicate definition of the database in test_schema.py If all the tests pass, then conftest.py is being picked up and used correctly.

dr-rodriguez commented 5 months ago

I took the liberty of pushing some updates to this branch, namely:

Moving database tests to their own test file, test_database.py, for clarity
Updating the sample database contents (and a few of the tests) so they actually pass now
Minor updates to gitignore/coverage

dr-rodriguez commented 5 months ago

One good thing about these changes is that they actually test the sample data in this repo, which was actually not valid. With this change we should be able to catch any cases were we modify the sample data (or schema) and it breaks validation.

arjunsavel commented 5 months ago

Thanks for all your work on this, @dr-rodriguez !