search

astrodbtoolkit / astrodb-template-db

A template for astronomical databases.
https://astrodb-template-db.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

data integrity test: SIMBAD-resolvable sources? #64

Open arjunsavel opened 4 months ago

arjunsavel commented 4 months ago

do we want to test whether sources are simbad-resolvable?

arjunsavel commented 4 months ago

Pretty sure tests will fail — still working on this.

arjunsavel commented 3 months ago

we want to instead do this for the ingest_sources function. will make the tests take too long, and tests will fail if SIMBAD is down.

arjunsavel commented 3 months ago

SIMBAD as part of a set of monthly tests?

arjunsavel commented 3 months ago

todo: make this a ~monthly check.

kelle commented 3 months ago

In SIMPLE, we called it scheduled_checks.py so it's not auto-discovered by pytest.

Here's also the action file to use for inspiration. This runs every 30 days: https://github.com/SIMPLE-AstroDB/SIMPLE-db/blob/main/.github/workflows/scheduled-tests.yml

arjunsavel commented 2 months ago

thanks for all the comments!

dr-rodriguez commented 2 months ago

Tried running in CodeSpaces but this doesn't run as-is, so some more iteration is needed; see the comments above.

dr-rodriguez commented 2 months ago

Pushed a fix to the various issues I noticed above. The script runs successfully for me in CodeSpaces.

arjunsavel commented 2 weeks ago

todo: rename the files to be the source names