Add units expectations to ingest functions

[kelle]

In SIMPLE, we assume units and note what the expectation is in the docs. This is extremely error prone. Other options

• Include units in the column name. e.g., parallax_mas, parallax_error_mas
• Include units as a column in all tables with a measurement. We could then have a test to make sure that that string corresponds to a astropy unit.

[arjunsavel]

I think including in the column name is a bit more cumbersome, but especially in light of the Chen et al. 2022 recommendations, it makes sense to explicitly state units in columns.

Provide a clear title and unambiguous labels of columns. Indicate the units for each column when applicable. This is especially important when data are to be compared, or used outside a specialized field.

Thoughts?

[kelle]

I'm 50-50.

I'm leaning towards a dedicated units column. It's more flexible and makes things more interoperable. Also, easy to test. Harder to mess up since units have to be set deliberately.

[kelle]

Option: modify ingest scripts to expect Quantities and then the ingest functions convert to the desired unit. Have ignore_units option.

[kelle]

David doesn't like the idea of a units column. He is ok with having units in the column name.

[arjunsavel]

Not fully addressed yet - in a future PR still need to explicitly handle quantities on ingest.

[arjunsavel]

@kelle @dr-rodriguez for handling quantities on ingest...is that a feature we want to implement here or astrodb_scripts?

[kelle]

astrodb_scripts. I can move the issue.