search

astrodbtoolkit / astrodb_utils

https://astrodb-utils.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Update pythonpublish.yml #83

Closed kelle closed 1 month ago

kelle commented 1 month ago

Updating the workflow to publish to PyPI following this guide: https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#workflow-definition

dr-rodriguez commented 1 month ago

Do we want to delete the 0.2 tag after we merge this? The 0.2 is NOT using this mechanism since its behind

kelle commented 1 month ago

Do we want to delete the 0.2 tag after we merge this? The 0.2 is NOT using this mechanism since its behind

My plan was to trigger the workflow manually once this workflow is updated. But if that doesn't work, then yes, we need to make a new release. I'm ok with it being a new 0.2.1 rather than deleting 0.2.

dr-rodriguez commented 1 month ago

Do we want to delete the 0.2 tag after we merge this? The 0.2 is NOT using this mechanism since its behind

My plan was to trigger the workflow manually once this workflow is updated. But if that doesn't work, then yes, we need to make a new release. I'm ok with it being a new 0.2.1 rather than deleting 0.2.

The original workflow doesn't allow for manual execution (I think that's what worfklow_dispatch enables). But if you're OK with just pushing 0.2.1 then that's fine with me.

kelle commented 1 month ago

I'm stuck. 

400 The use of local versions in                              
         <Version('0.1.dev1+g4a4cdb0')> is not allowed. See                     
         https://packaging.python.org/specifications/core-metadata for more     
         information.</title>

Going to lunch.

kelle commented 1 month ago

Abandoned the testpypi recommended workflow since we (me and Lehman) couldn't figure out how to make it work with dynamic versioning. This workflow works the same way the old one did, just with the newer actions and authentication mechanism.