First of all: refactor the crazy js code

astrofrog / acknowledgment-generator

Easily generate acknowledgment sections for papers

http://astrofrog.github.io/acknowledgment-generator/

40 stars 47 forks source link

First of all: refactor the crazy js code #51

Closed onekiloparsec closed 7 years ago

onekiloparsec commented 8 years ago

Ongoing here: https://github.com/onekiloparsec/acknowledgment-generator

Will do a PR once I get an iso-features state.

@astrofrog Let me know if you want to participate.

astrofrog commented 8 years ago

Thanks!! I'm a total HTML + JS n00b :-/

onekiloparsec commented 8 years ago

I've made a lot of refactor. Not only in the javascript, but also in the python script that generate the JSON file. I've added basic Twitter bootstrap style.

It is unclear to me the purpose of all the stuff you were doing with a delimiter in the old JS code. And what about the Facilities and Bibtex parts: how exactly they are built. Could you clone my fork and have a check?

I'll give you access to my fork for you to push right into it if necessary.

astrofrog commented 7 years ago

Done in #52 - thanks @onekiloparsec!