Refactor of the page & code

astrofrog / acknowledgment-generator

Easily generate acknowledgment sections for papers

http://astrofrog.github.io/acknowledgment-generator/

40 stars 47 forks source link

Refactor of the page & code #52

Closed onekiloparsec closed 8 years ago

onekiloparsec commented 8 years ago

Updated the generator with:

More modern-looking style, easily-configurable, responsive with Twitter Bootstrap framework
A cleaner separation of concerns (html, data, js, code etc...)
A lot simpler javascript code, and better use of jQuery
An updated page_entries python script to produce a more sensible json data file.
The clear display and handling of acknowledgment dependencies
A small signature at the bottom

What do you think?

onekiloparsec commented 8 years ago

This PR fixes #51 .

astrofrog commented 8 years ago

Wow, this looks great, thank you so much for refactoring everything! One minor thing - the focus rectangle around the search box (at least in Safari) appears truncated on the right:

Is that easy to fix?

onekiloparsec commented 8 years ago

Strangely, it is not truncated in my Safari... I don't know what I could do then. I just changed a little thing because the search box was too large in small screens. But I don't know if that will improve your case. You may want to play a bit with the search input CSS properties in style.css.

onekiloparsec commented 8 years ago

Do you need something else before merging the PR? I've been unable to reproduce your problem, unfortunately. Let me know if I can improve a bit more.

astrofrog commented 8 years ago

@onekiloparsec - thanks for all this work, and sorry for the delay in merging! (was afk for the last few days).

astrofrog commented 8 years ago

@onekiloparsec - the search box looks fine now btw, thanks!

onekiloparsec commented 8 years ago

Thanks!