search

astrofrog / psrecord

Record the CPU and memory activity of a process :chart_with_upwards_trend:
BSD 2-Clause "Simplified" License
591 stars 76 forks source link

setup.py: Add matplotlib #53

Closed JohnAZoidberg closed 4 months ago

JohnAZoidberg commented 5 years ago

It's imported in psrecord/main.py but not installed by setuptools. Is that okay or do you want it to be optional like this?

codecov-io commented 5 years ago

Codecov Report

Merging #53 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #53   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         158    158           
=====================================
  Hits          158    158
Impacted Files Coverage Δ
psrecord/main.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aff9389...56d1087. Read the comment docs.

JohnAZoidberg commented 5 years ago

Alright, did it :)

JohnAZoidberg commented 5 years ago

Is this ok?

codecov-commenter commented 3 years ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

astrofrog commented 4 months ago

@JohnAZoidberg - sorry for dropping the ball on this, I've rebased this and fixed the testing