search

astrofrog / pyavm

Pure-python AVM library
http://astrofrog.github.io/pyavm/
Other
20 stars 9 forks source link

added coordinate_frame reading in from_wcs #11

Closed keflavich closed 11 years ago

keflavich commented 11 years ago

from_wcs does not set CoordinateFrame in master, so it defaults to J2000 / ICRS always. This PR now parses wcs.wcs.ctype to determine a valid Frame. However, it defaults to ICRS for RA/Dec - how do you choose fk5, fk4?

astrofrog commented 11 years ago

@keflavich - to get the current PR to pass, you'll need to change the strings like 'GLON' to bytes, so b'GLON' because astropy.wcs returns byte strings, not unicode strings.

For your other question, see the table here:

http://virtualastronomy.org/avm_1.1_ref_table_final_draft.pdf

and appendix A here:

http://virtualastronomy.org/avm_1.1_final_draft.pdf

Thanks for working on this!

astrofrog commented 11 years ago

Thanks for this! I've tidied it up a little (along with other fixes) here: astrofrog/pyavm#15

keflavich commented 11 years ago

Thanks. I've already been using it in "production-level" code, so thanks for putting pyavm together!