search

astrofrog / robo-ph

#dotastro hack
3 stars 2 forks source link

Substitutions #27

Open bamford opened 8 years ago

bamford commented 8 years ago

Does substitutions.txt get used anywhere yet? I can't find it mentioned in the code.

Do you have a plan for building the substitutions list? Interested in a fork and PR? There are so many little tweaks that I think of while listening (everyday so far - great for in the car!).

astrofrog commented 8 years ago

They aren't used anywhere yet, but should be done around here:

https://github.com/astrofrog/robo-ph/blob/master/roboph.py#L86

Please do feel free to do a pull request with suggested improvements! (if possible, one 'idea' per pull request rather than one monolithic PR with all changes)

astrofrog commented 8 years ago

Just to clarify, you can just do one PR with all suggested substitutions, what I meant is more that if you want to modify some of the Python code in various places, then it might be worth not doing one large PR. But one PR for all substitutions is fine.