search

astrofrog / sedfitter

Python version of the SED fitter from Robitaille et al., 2007, ApJS 169 328
http://sedfitter.readthedocs.org
BSD 2-Clause "Simplified" License
20 stars 22 forks source link

Add check for filter ordering #59

Open astrofrog opened 6 years ago

astrofrog commented 6 years ago

Filters have to be ordered by increasing frequency, but we should explicitly check this.

mpound commented 6 years ago

I second this! Or at least make it clear in the doc for Filter.read() and in the example section "Preparing Filters". (blink tag, anyone?) My model convolution was always coming up with zeros because Filter.rebin() requires frequency increasing order. Took me a while to figure out this was the source of the problem. If I hadn't remembered seeing this issue, I may never have solved it. I'd be happy to edit the doc on github to make this clear, if you agree.

Marc