search

astrofrog / sedfitter

Python version of the SED fitter from Robitaille et al., 2007, ApJS 169 328
http://sedfitter.readthedocs.org
BSD 2-Clause "Simplified" License
20 stars 22 forks source link

Subsequent fitting after filter_output()? #61

Open mattpovich opened 6 years ago

mattpovich commented 6 years ago

Hi Tom,

Looking for some features from the old fortran version that I found useful, perhaps you've implemented them somewhere already but I've missed it in the documentation...

Do you have a utility to produce new files in the fitter data format from the binary output.* files? Like the old fits2data when the output files were fits tables?

Also would be helpful if filter_output printed the number of well-fit and poorly-fit sources to the terminal, I've always found this to be a useful sanity check when fitting large batches of sources.

Cheers,

Matt

astrofrog commented 6 years ago

Do you have a utility to produce new files in the fitter data format from the binary output.* files? Like the old fits2data when the output files were fits tables?

This would be useful, but doesn't exist at the moment. Unfortunately I don't really have time/funding to work on adding new features, but if you fancy having a try, you could try and write a script, using filter_output as a starting point and then also reading in the data file and doing the filtering yourself based on source name?

Also would be helpful if filter_output printed the number of well-fit and poorly-fit sources to the terminal, I've always found this to be a useful sanity check when fitting large batches of sources.

This sounds useful - similarly to above, maybe you could make a copy of filter_output.py that you can modify to add this - if the changes are minimal you could always send me the fixed file and I can incorporate the changes here.

mattpovich commented 6 years ago

I have written a utility that does both of these tasks — but in IDL because I was in a rush and I'm still a rank novice with python! If anyone is interested in the IDL version I'm happy to share. I'll see if I can produce a python version down the road.

On Thu, Jul 26, 2018 at 6:39 AM Thomas Robitaille notifications@github.com wrote:

Do you have a utility to produce new files in the fitter data format from the binary output.* files? Like the old fits2data when the output files were fits tables?

This would be useful, but doesn't exist at the moment. Unfortunately I don't really have time/funding to work on adding new features, but if you fancy having a try, you could try and write a script, using filter_output as a starting point and then also reading in the data file and doing the filtering yourself based on source name?

Also would be helpful if filter_output printed the number of well-fit and poorly-fit sources to the terminal, I've always found this to be a useful sanity check when fitting large batches of sources.

This sounds useful - similarly to above, maybe you could make a copy of filter_output.py that you can modify to add this - if the changes are minimal you could always send me the fixed file and I can incorporate the changes here.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/astrofrog/sedfitter/issues/61#issuecomment-408100542, or mute the thread https://github.com/notifications/unsubscribe-auth/AnrfIHKoojmRBvIEBNh6ZXYYbFVLgvZFks5uKcZ6gaJpZM4VcFWS .

-- --

Matthew S. Povich Associate Professor Department of Physics and Astronomy College of Science Building 8, Rm 216 Cal Poly Pomona http://www.cpp.edu/~mspovich/ mspovich@cpp.edu Office: (909) 869-3608 Mobile: (617) 306-0411