search

astrofrog / wcsaxes

wcsaxes has been merged into astropy!
http://docs.astropy.org/en/stable/visualization/wcsaxes/index.html
22 stars 21 forks source link

Test failures due to new Galactic <-> FK5 conversion in Astropy #142

Closed astrofrog closed 10 years ago

astrofrog commented 10 years ago

In Astropy 1.0.dev there is a subtle change in Galactic <-> FK5 conversion which is causing two tests to fail. One of these is an image test. We need to find a good mechanism for dealing with reference images that change with versions of e.g. astropy (or matplotlib).

cdeil commented 10 years ago

A simple way would be to only test the latest version and skip the test on older versions as described here: https://gammapy.readthedocs.org/en/latest/development/index.html#skip-unit-tests-for-some-astropy-versions

I think that's acceptable (at least in this case), no need to put too much thought / coding effort into testing old, soon outdated versions.

astrofrog commented 10 years ago

Good idea, I'll do that

cdeil commented 10 years ago

Do you think a test helper decorator (something like requires_astropy('>0.4')) would be useful enough to be worth implementing in Astropy?

astrofrog commented 10 years ago

@cdeil - see attached fix, which essentially does this

astrofrog commented 10 years ago

@cdeil - and yes, I think we might want to have some kind of helper in astropy since this will be common.