search

astrofrog / wcsaxes

wcsaxes has been merged into astropy!
http://docs.astropy.org/en/stable/visualization/wcsaxes/index.html
22 stars 21 forks source link

Fixing miniconda path in .travis.xml and updating helpers #180

Closed bsipocz closed 8 years ago

bsipocz commented 9 years ago

Miniconda's default prefix changed recently causing all travis builds failing.

And while I was at it I've updated the helpers to the latest one.

bsipocz commented 8 years ago

@astrofrog - Do you want to use ci-helpers here, too? If yes I can update this PR.

astrofrog commented 8 years ago

@bsipocz - yes, that would be great, thanks!

bsipocz commented 8 years ago

Some of the tests fail with the OrderedDict issue, and many fail with pytest-mpl. I guess we should fix mpl version to 1.4.3 to get them pass?

astrofrog commented 8 years ago

@bsipocz - yes, that might make sense for now. I can look at the pytest-mpl issues today. Can you update the OrderedDict imports?

bsipocz commented 8 years ago

It's already in #184

bsipocz commented 8 years ago

Do you want appveyor, too?

astrofrog commented 8 years ago

@bsipocz - I'm not sure if the image testing will work on Windows, so maybe we can do that in another PR once one of us has time

bsipocz commented 8 years ago

Ohh, sure, I've already forgot about the image testing issues. That case it should be definitely a new PR.

bsipocz commented 8 years ago

@astrofrog - now I've rebased this on #184, so it should pass and be ready for review.

astrofrog commented 8 years ago

@bsipocz - I think the remaining issue is because you need to change the language to c and set PYTHON_VERSION manually (like we do in the core package). Otherwise it tries to get a built-in 3.5, which doesn't seem to work.

bsipocz commented 8 years ago

@astrofrog - Could you please restart that build? It didn't fail before, and the last commit didn't touch any 3.5 related stuff so I think it's very probably just a random fail.

astrofrog commented 8 years ago

Thank you very much @bsipocz! :)