Closed astrogilda closed 3 months ago
On Fri, Mar 29, 2024, 6:54 PM Franz Király @.***> wrote:
@.**** requested changes on this pull request.
- removal makes sense
- do we want to add all that stuff to the dev dep set? Not sure if we even need it?
- are the changes in tests/test_time_series_simulator.py accidental or intentionally in this PR?
— Reply to this email directly, view it on GitHub https://github.com/astrogilda/tsbootstrap/pull/115#pullrequestreview-1969667627, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFTOOHSN5MPTADA5EZXJQTLY2XPHRAVCNFSM6AAAAABFNUPVCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRZGY3DONRSG4 . You are receiving this because you were assigned.Message ID: @.***>
could you delineate the packages you think are not required? @fkiraly
My default guess would be, strictly speaking none, since the CI had worked fine before that?
A slightly more permissive guess would be, only packages that are being mentioned in the contributor guide? E.g., to lint your code, do xyz. Or, those referenced in pre-commit-config
?
Pull Request Template
Description
Removed pyproject.xyz sections. Trying to see if
poetry add tsbootstrap
andpoetry add tsbootstrap -E all-extras
will work, just aspip install tsbootstrap
andpip install tsbootstrap[all-extras]
does.Type of change
Please delete options that are not relevant.
Checklist: