search

astrogilda / tsbootstrap

tsbootstrap: generate bootstrapped time series samples in Python
https://tsbootstrap.readthedocs.io/en/latest/
MIT License
65 stars 5 forks source link

n_bootstraps for MovingBootstrap doesn't work (n is still 10). #157

Closed oldrichsmejkal closed 1 week ago

oldrichsmejkal commented 3 weeks ago

Describe the bug A clear and concise description of what the bug is.

n_bootstraps for MovingBootstrap doesn't work (n is still 10).

Seems like just adding n_bootstrap to MovingBlockBootstrapConfig like below solves the problem: self.config = MovingBlockBootstrapConfig( n_bootstraps = n_bootstraps, ...

(tsbootstrap/block_bootstrap.py: 402)

benHeid commented 3 weeks ago

I think it is fixed on main. See #154

@astrogilda would it make sense to make a minor release with the bugfix?

astrogilda commented 3 weeks ago

@benHeid I think you are absolutely right. I'll aim for this weekend, with this plus a couple of other fixes that @fkiraly has suggested about a month or so ago. @oldrichsmejkal give me a few days :)

astrogilda commented 1 week ago

@oldrichsmejkal this is now fixed with 0.1.2. closing the issue.