search

astrogilda / tsbootstrap

tsbootstrap: generate bootstrapped time series samples in Python
https://tsbootstrap.readthedocs.io/en/latest/
MIT License
69 stars 5 forks source link

feat: `scikit-base` testing with `hypothesis` parameter samples #75

Open fkiraly opened 7 months ago

fkiraly commented 7 months ago

Experimental - combines scikit-base machinery with hypothesis based sampling for estimator parameter.s

This is achieved by allowing an extender to provide hypothesis strategies to a delegate of get_test_params, and then using the sampled examples in TestAllBootstraps.

Currently covers only n_bootstraps, this Pr is meant to showcase the design and general extension principle.

Open questions:

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 76.19048% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 88.41%. Comparing base (5d53806) to head (2c2a125). Report is 87 commits behind head on main.

:exclamation: Current head 2c2a125 differs from pull request most recent head cb3048b. Consider uploading reports for the commit cb3048b to get more accurate results

Files Patch % Lines
src/tsbootstrap/utils/random_state.py 0.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== + Coverage 84.77% 88.41% +3.64% ========================================== Files 17 32 +15 Lines 2607 2805 +198 ========================================== + Hits 2210 2480 +270 + Misses 397 325 -72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fkiraly commented 5 months ago

Failures seem genuine - any tipps?

astrogilda commented 5 months ago

Failures seem genuine - any tipps?

I agree -- I plan to tackle this on Friday/over the weekend. Should have more clarity then.

fkiraly commented 4 months ago

any updates, @astrogilda?

astrogilda commented 4 months ago

Haven't been able to touch this yet, apologies! Work related responsibilities. It's definitely on the horizon. Will try to get to it asap -- ideally this weekend, since there are no pressing deadlines I can think of right now.

On Tue, May 28, 2024, 8:44 AM Franz Király @.***> wrote:

any updates, @astrogilda https://github.com/astrogilda?

— Reply to this email directly, view it on GitHub https://github.com/astrogilda/tsbootstrap/pull/75#issuecomment-2135128924, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFTOOHX662D2HEFXKCVYJCDZER34DAVCNFSM6AAAAABDNLTNU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVGEZDQOJSGQ . You are receiving this because you were mentioned.Message ID: @.***>