astroidmail / astroid

A graphical threads-with-tags style, lightweight and fast, e-mail client for Notmuch
http://astroidmail.github.io
Other
613 stars 65 forks source link

Editing the "from" field in the editor and lose the content #292

Closed hugoroy closed 7 years ago

hugoroy commented 7 years ago

If I write an email and try to change the 'from' field in the editor itself, I lose the content of the email I juste wrote when I quit the editor.

gauteh commented 7 years ago

Hugo Roy writes on februar 25, 2017 20:08:

If I write an email and try to change the 'from' field in the editor itself, I lose the content of the email I juste wrote.

Oh, that's bad. Is this with the external editor? Is the new from field value a valid e-mail? (one that is registered as an account in the astroid config).

hugoroy commented 7 years ago

↪ Gaute Hope / février 25, 2017 22:29:

Oh, that's bad. Is this with the external editor?

Yes, emacs in my case.

Is the new from field value a valid e-mail? (one that is registered as an account in the astroid config).

Yes it is valid. Yes, it is also an account.

The problem is, I can't always produce this bug, but I've noticed that that sometimes happen (which is why I have grown a habit of being careful with editing the "From" field from the editor... but I sometimes still do it).

gauteh commented 7 years ago

Does this only happen when any of the involved accounts has a signature?

hugoroy commented 7 years ago

It does not seem to be related to that.

But it seems I can always produce the bug when I am writing a New email (as opposed to replying to an existing email).

gauteh commented 7 years ago

I cannot reproduce this. Could you post a log with a minimum of other stuff going on?

hugoroy commented 7 years ago

↪ Gaute Hope / février 26, 2017 17:24:

I cannot reproduce this. Could you post a log with a minimum of other stuff going on?

So here's what I did.

  1. Write a new mail (not replying to an existing email).
  2. Edit the From field (showing the default email address) by replacing with another (valid) email address used for another account - Edit the email subject and the email body, save and quit Emacs editor
  3. The From address has changed appropriately but the subject and content of the email is lost.
  4. Then I quit.

Here's the full log (If that helps, I uploaded my astroid config to https://github.com/hugoroy/.astroid).

[18:59:41.558526] [0x00007ff634713340] [debug] mw: focus-in: 1 active: true, in_quit: false
[18:59:42.123624] [0x00007ff634713340] [info] re: using installed resource: /usr/share/astroid/ui/edit-message.glade
[18:59:42.126287] [0x00007ff634713340] [info] em: msg id: 1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:42.126307] [0x00007ff634713340] [info] em: tmpfile: "/home/hugo/.cache/astroid/1488131982.lgiyq7ixeu.hugo@local.fqdn"
[18:59:42.126822] [0x00007ff634713340] [debug] theme: loading..
[18:59:42.126848] [0x00007ff634713340] [info] re: using user configured resource: /home/hugo/ui/thread-view.html
[18:59:42.126879] [0x00007ff634713340] [debug] tv: testing version: 4
[18:59:42.126895] [0x00007ff634713340] [info] re: using user configured resource: /home/hugo/ui/thread-view.scss
[18:59:42.126913] [0x00007ff634713340] [debug] tv: testing version: 4
[18:59:42.126937] [0x00007ff634713340] [info] theme: processing: /home/hugo/.config/astroid/ui/thread-view.scss
[18:59:42.152617] [0x00007ff634713340] [info] key: binding unbound target: 
[18:59:42.154796] [0x00007ff634713340] [debug] em: preparing message from fields..
[18:59:42.154958] [0x00007ff634713340] [debug] em: prepare message done.
[18:59:42.156060] [0x00007ff634713340] [debug] em: editor toggle: false
[18:59:42.156105] [0x00007ff634713340] [debug] cm: initialize..
[18:59:42.156170] [0x00007ff634713340] [info] msg: loading message from file (mid supplied): /home/hugo/.cache/astroid/1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:42.156347] [0x00007ff634713340] [debug] chunk (0): content-type: text/plain
[18:59:42.156383] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:42.156391] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:42.156446] [0x00007ff634713340] [debug] chunk: body: part
[18:59:42.156454] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[18:59:42.156476] [0x00007ff634713340] [warning] charset: not defined.
[18:59:42.156513] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:42.156541] [0x00007ff634713340] [debug] cm: build..
[18:59:42.156622] [0x00007ff634713340] [debug] cm: finalize..
[18:59:42.156705] [0x00007ff634713340] [debug] same account: true
[18:59:42.156870] [0x00007ff634713340] [info] cm: wrote tmp file: /tmp/astroid-compose-PcYa16
[18:59:42.156893] [0x00007ff634713340] [info] msg: loading message from file: 
[18:59:42.157001] [0x00007ff634713340] [debug] chunk (1): content-type: text/plain
[18:59:42.157018] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:42.157026] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:42.157050] [0x00007ff634713340] [info] render: loading html..
[18:59:42.157323] [0x00007ff634713340] [info] tv: navigation action: 5
[18:59:42.157345] [0x00007ff634713340] [info] tv: navigating to: /home/hugo/.config/astroid/k8rbqgfobev3929bq12jpybigpb4sl96bjy13216et6ufhxdrz7ha92golbhnedek4v2mtfc2wv5441eo09zesbx4v1nfqlvjqty5tpa2mgl17ntf79wj70u
[18:59:42.157384] [0x00007ff634713340] [debug] tv: on_load_changed: 0
[18:59:42.157524] [0x00007ff634713340] [debug] cm: deinitialized.
[18:59:42.157970] [0x00007ff634713340] [debug] em: editor toggle: true
[18:59:42.157982] [0x00007ff634713340] [debug] em: preparing message from fields..
[18:59:42.158075] [0x00007ff634713340] [debug] em: prepare message done.
[18:59:42.158087] [0x00007ff634713340] [debug] em: ex: launching editor: emacsclient -q -c /home/hugo/.cache/astroid/1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:42.179021] [0x00007ff634713340] [debug] tv: on_load_changed: 1
[18:59:42.243436] [0x00007ff634713340] [debug] tv: on_load_changed: 3
[18:59:42.243777] [0x00007ff634713340] [debug] tv: on_load_changed: 2
[18:59:42.243859] [0x00007ff634713340] [debug] tv: load finished.
[18:59:42.264210] [0x00007ff634713340] [debug] render: html loaded, building messages..
[18:59:42.264382] [0x00007ff634713340] [debug] tv: adding message: 1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:42.266086] [0x00007ff634713340] [debug] gravatar: for: hugo@DEFAULTEMAIL, uri: https://www.gravatar.com/avatar/19188dd148e4bb0163194085abd3d2a8?d=retro&s=48
[18:59:42.283864] [0x00007ff634713340] [debug] create message part: 1 (siblings: 0) (kids: 0) (attachment: false) (viewable: true) (mimetype: text/plain)
[18:59:42.283923] [0x00007ff634713340] [debug] create body part: 1
[18:59:42.283987] [0x00007ff634713340] [debug] chunk: body: part
[18:59:42.284004] [0x00007ff634713340] [debug] chunk: plain text (out html: true)
[18:59:42.284031] [0x00007ff634713340] [debug] enc: quoted-printable
[18:59:42.284053] [0x00007ff634713340] [debug] charset: utf-8
[18:59:42.284251] [0x00007ff634713340] [debug] tv: make preview..
[18:59:42.284269] [0x00007ff634713340] [debug] chunk: body: part
[18:59:42.284280] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[18:59:42.284293] [0x00007ff634713340] [debug] enc: quoted-printable
[18:59:42.284305] [0x00007ff634713340] [debug] charset: utf-8
[18:59:42.285550] [0x00007ff634713340] [info] tv: ready emitted.
[18:59:42.285592] [0x00007ff634713340] [debug] em: got tv ready.
[18:59:42.285715] [0x00007ff634713340] [debug] tv: set info: Editing..
[18:59:52.510014] [0x00007ff634713340] [debug] em: ex: file changed, updating preview..
[18:59:52.510120] [0x00007ff634713340] [debug] cm: initialize..
[18:59:52.510231] [0x00007ff634713340] [info] msg: loading message from file (mid supplied): /home/hugo/.cache/astroid/1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:52.510568] [0x00007ff634713340] [debug] chunk (2): content-type: text/plain
[18:59:52.510630] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.510655] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.510832] [0x00007ff634713340] [debug] chunk: body: part
[18:59:52.510870] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[18:59:52.510910] [0x00007ff634713340] [warning] charset: not defined.
[18:59:52.511000] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.511057] [0x00007ff634713340] [debug] cm: build..
[18:59:52.511154] [0x00007ff634713340] [debug] cm: finalize..
[18:59:52.511411] [0x00007ff634713340] [debug] em: preparing message from fields..
[18:59:52.511747] [0x00007ff634713340] [debug] em: prepare message done.
[18:59:52.511803] [0x00007ff634713340] [debug] cm: initialize..
[18:59:52.511889] [0x00007ff634713340] [info] msg: loading message from file (mid supplied): /home/hugo/.cache/astroid/1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:52.512140] [0x00007ff634713340] [debug] chunk (3): content-type: text/plain
[18:59:52.512196] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.512227] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.512360] [0x00007ff634713340] [debug] chunk: body: part
[18:59:52.512397] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[18:59:52.512442] [0x00007ff634713340] [warning] charset: not defined.
[18:59:52.512503] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.512553] [0x00007ff634713340] [debug] cm: build..
[18:59:52.512636] [0x00007ff634713340] [debug] cm: finalize..
[18:59:52.512761] [0x00007ff634713340] [debug] same account: true
[18:59:52.513049] [0x00007ff634713340] [info] cm: wrote tmp file: /tmp/astroid-compose-m2iBli
[18:59:52.513109] [0x00007ff634713340] [info] msg: loading message from file: 
[18:59:52.513390] [0x00007ff634713340] [debug] chunk (4): content-type: text/plain
[18:59:52.513447] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.513474] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.513544] [0x00007ff634713340] [info] render: loading html..
[18:59:52.513812] [0x00007ff634713340] [info] tv: navigation action: 5
[18:59:52.513861] [0x00007ff634713340] [info] tv: navigating to: /home/hugo/.config/astroid/nq295vhkx7qxaqob218s82tf1woa8ud2o4kjwp9o5djessmbt6ctoesh7symobqibsszvke3tb9mo5f68oxqv0kuhj2pi6505hz2xgdkx9vk1ts47al2grzw
[18:59:52.513996] [0x00007ff634713340] [debug] tv: on_load_changed: 0
[18:59:52.514792] [0x00007ff634713340] [debug] cm: deinitialized.
[18:59:52.514891] [0x00007ff634713340] [debug] same account: false
[18:59:52.515230] [0x00007ff634713340] [info] cm: wrote tmp file: /tmp/astroid-compose-bxxlGt
[18:59:52.515291] [0x00007ff634713340] [info] msg: loading message from file: 
[18:59:52.515613] [0x00007ff634713340] [debug] chunk (5): content-type: text/plain
[18:59:52.515668] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.515697] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.515746] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.515802] [0x00007ff634713340] [info] render: loading html..
[18:59:52.516027] [0x00007ff634713340] [info] tv: navigation action: 5
[18:59:52.516066] [0x00007ff634713340] [info] tv: navigating to: /home/hugo/.config/astroid/r30dfpywz02dnmzcqvqyveui1tbwqkxi284n905bt7s5ucrg9thhbzkkqxmzh77u2q7jmyjzwnaatg9wcfu6gtl9dc068qb0dpdyfp3jmd5ec8s43aa5d8lp
[18:59:52.516235] [0x00007ff634713340] [debug] tv: on_load_changed: 4
[18:59:52.516352] [0x00007ff634713340] [debug] tv: on_load_changed: 0
[18:59:52.516638] [0x00007ff634713340] [debug] cm: deinitialized.
[18:59:52.516772] [0x00007ff634713340] [debug] em: ex: file changed, updating preview..
[18:59:52.516815] [0x00007ff634713340] [debug] cm: initialize..
[18:59:52.516889] [0x00007ff634713340] [info] msg: loading message from file (mid supplied): /home/hugo/.cache/astroid/1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:52.517137] [0x00007ff634713340] [debug] chunk (6): content-type: text/plain
[18:59:52.517182] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.517202] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.517325] [0x00007ff634713340] [debug] chunk: body: part
[18:59:52.517364] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[18:59:52.517405] [0x00007ff634713340] [warning] charset: not defined.
[18:59:52.517467] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.517518] [0x00007ff634713340] [debug] cm: build..
[18:59:52.517604] [0x00007ff634713340] [debug] cm: finalize..
[18:59:52.517742] [0x00007ff634713340] [debug] same account: true
[18:59:52.518018] [0x00007ff634713340] [info] cm: wrote tmp file: /tmp/astroid-compose-QwUv1E
[18:59:52.518078] [0x00007ff634713340] [info] msg: loading message from file: 
[18:59:52.518351] [0x00007ff634713340] [debug] chunk (7): content-type: text/plain
[18:59:52.518405] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.518433] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.518479] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.518548] [0x00007ff634713340] [info] render: loading html..
[18:59:52.518771] [0x00007ff634713340] [info] tv: navigation action: 5
[18:59:52.518816] [0x00007ff634713340] [info] tv: navigating to: /home/hugo/.config/astroid/0qv2orazupnvm77isq6wjg6qzvf0g2cjwnd4l6mx6qz6x5e6lfeyro7gxpph2eo4pigt320t0mqyodw766z6mk3rbuta9gmdlbl72iqm63qttyzu40r9a3z1
[18:59:52.518952] [0x00007ff634713340] [debug] tv: on_load_changed: 4
[18:59:52.519075] [0x00007ff634713340] [debug] tv: on_load_changed: 0
[18:59:52.519405] [0x00007ff634713340] [debug] cm: deinitialized.
[18:59:52.520016] [0x00007ff634713340] [debug] em: ex: file changed, updating preview..
[18:59:52.520234] [0x00007ff634713340] [debug] cm: initialize..
[18:59:52.520402] [0x00007ff634713340] [info] msg: loading message from file (mid supplied): /home/hugo/.cache/astroid/1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:52.520888] [0x00007ff634713340] [debug] chunk (8): content-type: text/plain
[18:59:52.521019] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.521049] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.521290] [0x00007ff634713340] [debug] chunk: body: part
[18:59:52.521348] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[18:59:52.521412] [0x00007ff634713340] [warning] charset: not defined.
[18:59:52.521543] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.521625] [0x00007ff634713340] [debug] cm: build..
[18:59:52.521763] [0x00007ff634713340] [debug] cm: finalize..
[18:59:52.522019] [0x00007ff634713340] [debug] same account: true
[18:59:52.522532] [0x00007ff634713340] [info] cm: wrote tmp file: /tmp/astroid-compose-n88jnQ
[18:59:52.522655] [0x00007ff634713340] [info] msg: loading message from file: 
[18:59:52.523109] [0x00007ff634713340] [debug] chunk (9): content-type: text/plain
[18:59:52.523211] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.523231] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.523273] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.523337] [0x00007ff634713340] [info] render: loading html..
[18:59:52.523577] [0x00007ff634713340] [info] tv: navigation action: 5
[18:59:52.523630] [0x00007ff634713340] [info] tv: navigating to: /home/hugo/.config/astroid/6m0v5f3qt3t9tuy9u7bqyxdgfo51h0oonyt5xa1oklc74udzulr8zpbfo4zgb1plk3jpm62ro3s74xmoxtvdw1wokdh8fwypboqtqfliiekg36yg4ttokbud
[18:59:52.523776] [0x00007ff634713340] [debug] tv: on_load_changed: 4
[18:59:52.523909] [0x00007ff634713340] [debug] tv: on_load_changed: 0
[18:59:52.524229] [0x00007ff634713340] [debug] cm: deinitialized.
[18:59:52.532968] [0x00007ff634713340] [debug] tv: on_load_changed: 1
[18:59:52.535703] [0x00007ff634713340] [debug] tv: on_load_changed: 3
[18:59:52.535884] [0x00007ff634713340] [debug] tv: on_load_changed: 2
[18:59:52.535906] [0x00007ff634713340] [debug] tv: load finished.
[18:59:52.539909] [0x00007ff634713340] [debug] render: html loaded, building messages..
[18:59:52.540076] [0x00007ff634713340] [debug] tv: adding message: 1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:52.541062] [0x00007ff634713340] [debug] gravatar: for: hugo@DOMAIN, uri: https://www.gravatar.com/avatar/8fbb91f5cbfaffa58537937bf6990e73?d=retro&s=48
[18:59:52.542917] [0x00007ff634713340] [debug] create message part: 9 (siblings: 0) (kids: 0) (attachment: false) (viewable: true) (mimetype: text/plain)
[18:59:52.543012] [0x00007ff634713340] [debug] create body part: 9
[18:59:52.543104] [0x00007ff634713340] [debug] chunk: body: part
[18:59:52.543126] [0x00007ff634713340] [debug] chunk: plain text (out html: true)
[18:59:52.543146] [0x00007ff634713340] [debug] enc: quoted-printable
[18:59:52.543162] [0x00007ff634713340] [debug] charset: utf-8
[18:59:52.544534] [0x00007ff634713340] [debug] tv: make preview..
[18:59:52.544638] [0x00007ff634713340] [debug] chunk: body: part
[18:59:52.544653] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[18:59:52.544675] [0x00007ff634713340] [debug] enc: quoted-printable
[18:59:52.544692] [0x00007ff634713340] [debug] charset: utf-8
[18:59:52.545850] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.545932] [0x00007ff634713340] [info] tv: ready emitted.
[18:59:52.545956] [0x00007ff634713340] [debug] em: got tv ready.
[18:59:52.546029] [0x00007ff634713340] [debug] tv: set info: Editing..
[18:59:52.559603] [0x00007ff634713340] [debug] em: editor toggle: false
[18:59:52.559650] [0x00007ff634713340] [debug] cm: initialize..
[18:59:52.559687] [0x00007ff634713340] [info] msg: loading message from file (mid supplied): /home/hugo/.cache/astroid/1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:52.559785] [0x00007ff634713340] [debug] chunk (10): content-type: text/plain
[18:59:52.559800] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.559807] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.559841] [0x00007ff634713340] [debug] chunk: body: part
[18:59:52.559849] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[18:59:52.559861] [0x00007ff634713340] [warning] charset: not defined.
[18:59:52.559878] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.559891] [0x00007ff634713340] [debug] cm: build..
[18:59:52.559915] [0x00007ff634713340] [debug] cm: finalize..
[18:59:52.559960] [0x00007ff634713340] [debug] same account: true
[18:59:52.560040] [0x00007ff634713340] [info] cm: wrote tmp file: /tmp/astroid-compose-GPrNO1
[18:59:52.560056] [0x00007ff634713340] [info] msg: loading message from file: 
[18:59:52.560117] [0x00007ff634713340] [debug] chunk (11): content-type: text/plain
[18:59:52.560127] [0x00007ff634713340] [debug] chunk: preferred.
[18:59:52.560132] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[18:59:52.560151] [0x00007ff634713340] [info] render: loading html..
[18:59:52.560240] [0x00007ff634713340] [info] tv: navigation action: 5
[18:59:52.560249] [0x00007ff634713340] [info] tv: navigating to: /home/hugo/.config/astroid/2kngw8u56etdf0r9oebl2jz7i7uebow9f053qstb6wvfzumzi9am2345rdo8n1qc1xyprxm9w9abgsq0ynv5aksf84e98805audz5if1lvnkg7zqzcn91t4r
[18:59:52.560544] [0x00007ff634713340] [debug] tv: on_load_changed: 0
[18:59:52.560625] [0x00007ff634713340] [debug] cm: deinitialized.
[18:59:52.562498] [0x00007ff634713340] [debug] tv: on_load_changed: 1
[18:59:52.563708] [0x00007ff634713340] [debug] tv: on_load_changed: 3
[18:59:52.563803] [0x00007ff634713340] [debug] tv: on_load_changed: 2
[18:59:52.563815] [0x00007ff634713340] [debug] tv: load finished.
[18:59:52.565320] [0x00007ff634713340] [debug] render: html loaded, building messages..
[18:59:52.565370] [0x00007ff634713340] [debug] tv: adding message: 1488131982.lgiyq7ixeu.hugo@local.fqdn
[18:59:52.565673] [0x00007ff634713340] [debug] gravatar: for: hugo@DOMAIN, uri: https://www.gravatar.com/avatar/8fbb91f5cbfaffa58537937bf6990e73?d=retro&s=48
[18:59:52.566223] [0x00007ff634713340] [debug] create message part: 11 (siblings: 0) (kids: 0) (attachment: false) (viewable: true) (mimetype: text/plain)
[18:59:52.566264] [0x00007ff634713340] [debug] create body part: 11
[18:59:52.566319] [0x00007ff634713340] [debug] chunk: body: part
[18:59:52.566331] [0x00007ff634713340] [debug] chunk: plain text (out html: true)
[18:59:52.566346] [0x00007ff634713340] [debug] enc: quoted-printable
[18:59:52.566355] [0x00007ff634713340] [debug] charset: utf-8
[18:59:52.566478] [0x00007ff634713340] [debug] tv: make preview..
[18:59:52.566496] [0x00007ff634713340] [debug] chunk: body: part
[18:59:52.566504] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[18:59:52.566516] [0x00007ff634713340] [debug] enc: quoted-printable
[18:59:52.566525] [0x00007ff634713340] [debug] charset: utf-8
[18:59:52.567308] [0x00007ff634713340] [debug] chunk: deconstruct.
[18:59:52.567368] [0x00007ff634713340] [info] tv: ready emitted.
[18:59:52.567382] [0x00007ff634713340] [debug] em: got tv ready.
[18:59:52.567443] [0x00007ff634713340] [debug] tv: set info: Edit message with 'Enter'.
[18:59:52.569889] [0x00007ff634713340] [debug] mw: focus-in: 1 active: true, in_quit: false
[18:59:56.026276] [0x00007ff634713340] [debug] mw: focus-in: 1 active: true, in_quit: false
[19:00:03.631150] [0x00007ff634713340] [debug] really quit?: 1
[19:00:03.631181] [0x00007ff634713340] [info] mw: Really quit?
[19:00:04.181280] [0x00007ff634713340] [info] mw: yes-no: got yes!
[19:00:04.181379] [0x00007ff634713340] [info] mw: quit: 1
[19:00:04.181948] [0x00007ff634713340] [warning] em: force quit, trying to save draft..
[19:00:04.182000] [0x00007ff634713340] [info] em: saving draft..
[19:00:04.182075] [0x00007ff634713340] [debug] cm: initialize..
[19:00:04.182233] [0x00007ff634713340] [info] msg: loading message from file (mid supplied): /home/hugo/.cache/astroid/1488131982.lgiyq7ixeu.hugo@local.fqdn
[19:00:04.182549] [0x00007ff634713340] [debug] chunk (12): content-type: text/plain
[19:00:04.182619] [0x00007ff634713340] [debug] chunk: preferred.
[19:00:04.182639] [0x00007ff634713340] [debug] chunk: is part (viewable: true, attachment: false) 
[19:00:04.182820] [0x00007ff634713340] [debug] chunk: body: part
[19:00:04.182859] [0x00007ff634713340] [debug] chunk: plain text (out html: false)
[19:00:04.182947] [0x00007ff634713340] [warning] charset: not defined.
[19:00:04.183027] [0x00007ff634713340] [debug] chunk: deconstruct.
[19:00:04.183096] [0x00007ff634713340] [debug] cm: build..
[19:00:04.183212] [0x00007ff634713340] [debug] cm: finalize..
[19:00:04.183890] [0x00007ff634713340] [debug] cm: wrote file: /home/hugo/.email/imap/ampoliros/Drafts/cur/1488131982.lgiyq7ixeu.hugo_xps.ampoliros.net
[19:00:04.183944] [0x00007ff634713340] [info] em: saved draft to: /home/hugo/.email/imap/ampoliros/Drafts/cur/1488131982.lgiyq7ixeu.hugo_xps.ampoliros.net
[19:00:04.184070] [0x00007ff634713340] [debug] cm: deinitialized.
[19:00:04.184120] [0x00007ff618fbd700] [info] db: open db read-write.
[19:00:04.184228] [0x00007ff618fbd700] [debug] db: rw-s: waiting for rw lock.. (r-o open: 0)
[19:00:04.184269] [0x00007ff618fbd700] [debug] db: rw-s lock acquired.
[19:00:04.185202] [0x00007ff618fbd700] [debug] db: open time: 2.263 ms.
[19:00:04.185278] [0x00007ff618fbd700] [info] db: adding draft message: /home/hugo/.email/imap/ampoliros/Drafts/cur/1488131982.lgiyq7ixeu.hugo_xps.ampoliros.net
[19:00:04.189322] [0x00007ff618fbd700] [info] db: closing db.
[19:00:04.193554] [0x00007ff634713340] [debug] em: deconstruct.
[19:00:04.203385] [0x00007ff634713340] [debug] astroid: quitting..
[19:00:04.203482] [0x00007ff634713340] [debug] actions: cleaning up remaining actions..
[19:00:04.231088] [0x00007ff618fbd700] [debug] db: rw: releasing lock.
[19:00:04.231167] [0x00007ff618fbd700] [debug] db: rw-s: releasing lock.
[19:00:04.231403] [0x00007ff634713340] [debug] searches: saving history..
[19:00:04.231465] [0x00007ff634713340] [info] searches: loading saved searches..
[19:00:04.231961] [0x00007ff634713340] [info] searches: writing back saved searches..
[19:00:04.232265] [0x00007ff634713340] [debug] extension: destruct.
[19:00:04.232342] [0x00007ff634713340] [info] astroid: goodbye!
hugo@xps ~ % 
gauteh commented 7 years ago

Hugo Roy writes on februar 26, 2017 19:05:

↪ Gaute Hope / février 26, 2017 17:24:

I cannot reproduce this. Could you post a log with a minimum of other stuff going on?

So here's what I did.

  1. Write a new mail (not replying to an existing email).
  2. Edit the From field (showing the default email address) by replacing with another (valid) email address used for another account - Edit the email subject and the email body, save and quit Emacs editor
  3. The From address has changed appropriately but the subject and content of the email is lost.
  4. Then I quit.

Thanks, do you save the draft-buffer in emacs before quitting emacs? If you change the From: address, then save the buffer, do some more editing and save again before quitting emacs does it still happen?

-g

gauteh commented 7 years ago

Please test #293

hugoroy commented 7 years ago

↪ Gaute Hope / février 28, 2017 8:59:

Thanks, do you save the draft-buffer in emacs before quitting emacs? If you change the From: address, then save the buffer, do some more editing and save again before quitting emacs does it still happen?

If I edit the from, edit the rest, and then just save-quit: I lose the content.

If I edit the from, save, then try to edit: emacs warns be the file changed and asks me if I really want to edit the buffer. If I say yes, edit some more and save, it don't lose the content.

(Now compiling #292-fix-external-from-change)

hugoroy commented 7 years ago

↪ Gaute Hope / février 28, 2017 9:43:

Please test #293

It crashed when I modify the “From:” and save the buffer (does not crash if I don't modify the “From:” in emacs):

hugo@xps ~/.gitRepos/astroid (git)-[292-fix-external-from-change] % ./astroid 
[23:40:04.738746] [0x00007f007cb94a00] [info] welcome to astroid! - v0.6-184-g7e8dcff2
[23:40:04.738927] [0x00007f007cb94a00] [debug] utf8: true, UTF-8
[23:40:04.740715] [0x00007f007cb94a00] [debug] HOME: /home/hugo
[23:40:04.740784] [0x00007f007cb94a00] [info] cf: loading: "/home/hugo/.config/astroid/config"
[23:40:04.743405] [0x00007f007cb94a00] [info] cf: version: 7
[23:40:04.744605] [0x00007f007cb94a00] [error] config: option 'astroid.notmuch.db' is deprecated, it is read from notmuch config.
[23:40:04.744648] [0x00007f007cb94a00] [error] config: option 'astroid.notmuch.excluded_tags' is deprecated, it is read from notmuch config.
[23:40:04.744667] [0x00007f007cb94a00] [error] config: option 'astroid.notmuch.sent_tags' is deprecated, it is moved to 'mail.sent_tags'.
[23:40:04.744918] [0x00007f007cb94a00] [warning] cf: missing values in config have been updated with defaults (old version: 6, new: 7)
[23:40:04.744977] [0x00007f007cb94a00] [warning] cf: writing back config to: "/home/hugo/.config/astroid/config"
[23:40:04.745668] [0x00007f007cb94a00] [info] notmuch db: /home/hugo/.email/imap/
[23:40:04.745692] [0x00007f007cb94a00] [info] date: init.
[23:40:04.745993] [0x00007f007cb94a00] [info] keybindings: loading user bindings from: /home/hugo/.config/astroid/keybindings
[23:40:04.746043] [0x00007f007cb94a00] [debug] ky: parsing line: main_window.search=/
[23:40:04.746087] [0x00007f007cb94a00] [debug] ky: parsing line: thread_index.spam=X
[23:40:04.746108] [0x00007f007cb94a00] [debug] ky: parsing run-hook: thread_index.run(/home/hugo/.config/astroid/hooks/toggle waiting %1)=w
[23:40:04.746148] [0x00007f007cb94a00] [debug] ky: run: thread_index.run(w): /home/hugo/.config/astroid/hooks/toggle waiting %1
[23:40:04.746182] [0x00007f007cb94a00] [debug] ky: parsing run-hook: thread_index.run(/home/hugo/.config/astroid/hooks/toggle "unread -inbox" %1)=A
[23:40:04.746211] [0x00007f007cb94a00] [debug] ky: run: thread_index.run(A): /home/hugo/.config/astroid/hooks/toggle "unread -inbox" %1
[23:40:04.746226] [0x00007f007cb94a00] [debug] ky: parsing line: thread_view.next_message=j
[23:40:04.746243] [0x00007f007cb94a00] [debug] ky: parsing line: thread_view.previous_message=k
[23:40:04.746260] [0x00007f007cb94a00] [debug] ky: parsing line: thread_view.down=n
[23:40:04.746277] [0x00007f007cb94a00] [debug] ky: parsing line: thread_view.up=p
[23:40:04.746297] [0x00007f007cb94a00] [debug] ky: parsing line: thread_view.forward_inline=M-f
[23:40:04.746340] [0x00007f007cb94a00] [info] searches: loading saved searches..
[23:40:04.746626] [0x00007f007cb94a00] [debug] searches: loading history..
[23:40:04.746664] [0x00007f007cb94a00] [info] ac: initializing accounts..
[23:40:04.746786] [0x00007f007cb94a00] [info] ac: setup account: tosdr for Hugo Roy (default: false)
[23:40:04.746829] [0x00007f007cb94a00] [info] ac: setup account: fsfe for Hugo Roy (default: false)
[23:40:04.746872] [0x00007f007cb94a00] [info] ac: setup account: avocat for Hugo Roy (default: false)
[23:40:04.746915] [0x00007f007cb94a00] [info] ac: setup account: hugo for Hugo Roy (default: true)
[23:40:04.746941] [0x00007f007cb94a00] [info] plugins: starting manager..
[23:40:04.747053] [0x00007f007cb94a00] [debug] plugins: adding path: /usr/local/share/astroid/plugins
[23:40:04.747112] [0x00007f007cb94a00] [debug] plugin: adding path: /home/hugo/.config/astroid/plugins
[23:40:04.747140] [0x00007f007cb94a00] [debug] plugins: refreshing..
[23:40:04.747164] [0x00007f007cb94a00] [debug] plugins: found 0 plugins.
[23:40:04.747257] [0x00007f007cb94a00] [info] global actions: set up.
[23:40:04.747315] [0x00007f007cb94a00] [info] poll: setting up.
[23:40:04.747333] [0x00007f007cb94a00] [debug] poll: interval: 800
[23:40:04.747350] [0x00007f007cb94a00] [debug] poll: requested..
[23:40:04.747422] [0x00007f005affd700] [info] poll: polling: /home/hugo/.config/astroid/poll.sh
[23:40:04.747459] [0x00007f005affd700] [info] db: open db read-only, waiting for lock..
[23:40:04.747471] [0x00007f005affd700] [debug] db: read-only got lock.
[23:40:04.747544] [0x00007f007cb94a00] [warning] astroid: starting a new window..
[23:40:04.747834] [0x00007f005affd700] [debug] db: open time: 0.749 ms.
[23:40:04.747860] [0x00007f005affd700] [debug] poll: revision before poll: 1093040
[23:40:04.752335] [0x00007f005affd700] [info] db: closing db.
[23:40:04.752493] [0x00007f005affd700] [debug] db: ro: waiting for lock to close..
[23:40:04.752521] [0x00007f005affd700] [debug] db: ro: closing..
[23:40:04.759236] [0x00007f007cb94a00] [info] db: open db read-only, waiting for lock..
[23:40:04.759284] [0x00007f007cb94a00] [debug] db: read-only got lock.
[23:40:04.759420] [0x00007f007cb94a00] [debug] db: open time: 0.194 ms.
[23:40:04.760045] [0x00007f007cb94a00] [info] db: loaded 306 tags.
[23:40:04.764660] [0x00007f007cb94a00] [info] db: closing db.
[23:40:04.764762] [0x00007f007cb94a00] [debug] db: ro: waiting for lock to close..
[23:40:04.764777] [0x00007f007cb94a00] [debug] db: ro: closing..
[23:40:04.764793] [0x00007f007cb94a00] [debug] mw: init, id: 1
[23:40:04.780825] [0x00007f007cb94a00] [info] astroid: got query:      📥     : tag:inbox
[23:40:04.783939] [0x00007f007cb94a00] [info] re: using user configured resource: /home/hugo/.gitRepos/astroid/ui/no-mail.png
[23:40:04.785782] [0x00007f007cb94a00] [info] ky: run, binding: thread_index.run(w) (userdefined: true) to: /home/hugo/.config/astroid/hooks/toggle waiting %1
[23:40:04.785838] [0x00007f007cb94a00] [info] ky: run, binding: thread_index.run(A) (userdefined: true) to: /home/hugo/.config/astroid/hooks/toggle "unread -inbox" %1
[23:40:04.786458] [0x00007f007cb94a00] [debug] pm: add pane
[23:40:04.786626] [0x00007f005974d700] [info] db: open db read-only, waiting for lock..
[23:40:04.786713] [0x00007f005974d700] [debug] db: read-only got lock.
[23:40:04.786953] [0x00007f005974d700] [debug] db: open time: 0.637 ms.
[23:40:04.787638] [0x00007f007cb94a00] [debug] mw: does not have focus, will not grab modal.
[23:40:04.787712] [0x00007f007cb94a00] [debug] mw: does not have focus, will not grab modal.
[23:40:04.787738] [0x00007f007cb94a00] [debug] mw: does not have focus, will not grab modal.
[23:40:04.803341] [0x00007f005974d700] [error] address: more than one address in list!
[23:40:04.811313] [0x00007f007cb94a00] [info] poll: emitted poll state: true
[23:40:04.811663] [0x00007f007cb94a00] [info] db: open db read-only, waiting for lock..
[23:40:04.811688] [0x00007f007cb94a00] [debug] db: read-only got lock.
[23:40:04.811897] [0x00007f007cb94a00] [debug] db: open time: 0.236 ms.
[23:40:04.811927] [0x00007f007cb94a00] [debug] ql: refresh stats..
[23:40:04.813011] [0x00007f007cb94a00] [info] db: closing db.
[23:40:04.813054] [0x00007f007cb94a00] [debug] db: ro: waiting for lock to close..
[23:40:04.813072] [0x00007f007cb94a00] [debug] db: ro: closing..
[23:40:04.824048] [0x00007f007cb94a00] [warning] poll script: OfflineIMAP 7.0.13
[23:40:04.827462] [0x00007f007cb94a00] [warning] poll script:   Licensed under the GNU GPL v2 or any later version (with an OpenSSL exception)
[23:40:04.827539] [0x00007f007cb94a00] [warning] poll script: Account sync ampoliros:
[23:40:04.827978] [0x00007f007cb94a00] [warning] poll script:  *** Processing account ampoliros
[23:40:04.828021] [0x00007f007cb94a00] [warning] poll script:  Establishing connection to edge.ampoliros.net:993 (ampoliros.remote)
[23:40:04.864857] [0x00007f007cb94a00] [debug] mw: focus-in: 1 active: true, in_quit: false
[23:40:04.907004] [0x00007f007cb94a00] [debug] ql: loaded 100 threads.
[23:40:04.916499] [0x00007f005974d700] [info] db: closing db.
[23:40:04.916612] [0x00007f005974d700] [debug] db: ro: waiting for lock to close..
[23:40:04.916640] [0x00007f005974d700] [debug] db: ro: closing..

(astroid:19434): Gtk-WARNING **: Allocating size to gtkmm__GtkWindow 0xe02290 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
[23:40:06.019961] [0x00007f007cb94a00] [debug] mw: focus-in: 1 active: true, in_quit: false
[23:40:10.967225] [0x00007f007cb94a00] [warning] poll script: Folder Archive [acc: ampoliros]:
[23:40:10.972785] [0x00007f007cb94a00] [warning] poll script:  Syncing Archive: IMAP -> Maildir
[23:40:10.972892] [0x00007f007cb94a00] [warning] poll script: Folder Drafts [acc: ampoliros]:
[23:40:10.973045] [0x00007f007cb94a00] [warning] poll script:  Syncing Drafts: IMAP -> Maildir
[23:40:10.973091] [0x00007f007cb94a00] [warning] poll script: Folder Archive/2017 [acc: ampoliros]:
[23:40:10.974486] [0x00007f007cb94a00] [warning] poll script:  Syncing Archive/2017: IMAP -> Maildir
[23:40:10.974531] [0x00007f007cb94a00] [warning] poll script: Folder Drafts [acc: ampoliros]:
[23:40:10.975475] [0x00007f007cb94a00] [warning] poll script:  Establishing connection to edge.ampoliros.net:993 (ampoliros.remote)
[23:40:10.975560] [0x00007f007cb94a00] [warning] poll script: Folder Archive/2017 [acc: ampoliros]:
[23:40:11.351776] [0x00007f007cb94a00] [warning] poll script:  Establishing connection to edge.ampoliros.net:993 (ampoliros.remote)
[23:40:11.351865] [0x00007f007cb94a00] [warning] poll script: Folder INBOX [acc: ampoliros]:
[23:40:14.221223] [0x00007f007cb94a00] [debug] mw: focus-in: 1 active: true, in_quit: false
[23:40:14.590931] [0x00007f007cb94a00] [warning] poll script:  Syncing INBOX: IMAP -> Maildir
[23:40:14.591098] [0x00007f007cb94a00] [warning] poll script: Folder Sent [acc: ampoliros]:
[23:40:14.929118] [0x00007f007cb94a00] [info] re: using local resource: /home/hugo/.gitRepos/astroid/ui/edit-message.glade
[23:40:14.937751] [0x00007f007cb94a00] [info] em: msg id: 1488321614.35142oc69b.hugo@local.fqdn
[23:40:14.937888] [0x00007f007cb94a00] [info] em: tmpfile: "/home/hugo/.cache/astroid/1488321614.35142oc69b.hugo@local.fqdn"
[23:40:14.940122] [0x00007f007cb94a00] [debug] theme: loading..
[23:40:14.940263] [0x00007f007cb94a00] [info] re: using user configured resource: /home/hugo/.gitRepos/astroid/ui/thread-view.html
[23:40:14.940426] [0x00007f007cb94a00] [debug] tv: testing version: 4
[23:40:14.940509] [0x00007f007cb94a00] [info] re: using user configured resource: /home/hugo/.gitRepos/astroid/ui/thread-view.scss
[23:40:14.940587] [0x00007f007cb94a00] [debug] tv: testing version: 4
[23:40:14.941109] [0x00007f007cb94a00] [info] theme: processing: /home/hugo/.config/astroid/ui/thread-view.scss
[23:40:14.981145] [0x00007f007cb94a00] [info] key: binding unbound target: 
[23:40:14.983435] [0x00007f007cb94a00] [debug] em: preparing message from fields..
[23:40:14.983577] [0x00007f007cb94a00] [debug] em: prepare message done.
[23:40:14.984434] [0x00007f007cb94a00] [debug] em: editor toggle: false
[23:40:14.984465] [0x00007f007cb94a00] [debug] em: set info (ready: false): 
[23:40:14.984792] [0x00007f007cb94a00] [debug] em: editor toggle: true
[23:40:14.984811] [0x00007f007cb94a00] [debug] em: preparing message from fields..
[23:40:14.984900] [0x00007f007cb94a00] [debug] em: prepare message done.
[23:40:14.984920] [0x00007f007cb94a00] [debug] em: reading edited message..
[23:40:14.984935] [0x00007f007cb94a00] [debug] em: set warning (ready: false): 
[23:40:14.984954] [0x00007f007cb94a00] [debug] cm: initialize..
[23:40:14.985000] [0x00007f007cb94a00] [info] msg: loading message from file (mid supplied): /home/hugo/.cache/astroid/1488321614.35142oc69b.hugo@local.fqdn
[23:40:14.985129] [0x00007f007cb94a00] [debug] chunk (0): content-type: text/plain
[23:40:14.985158] [0x00007f007cb94a00] [debug] chunk: preferred.
[23:40:14.985168] [0x00007f007cb94a00] [debug] chunk: is part (viewable: true, attachment: false) 
[23:40:14.985218] [0x00007f007cb94a00] [debug] chunk: body: part
[23:40:14.985232] [0x00007f007cb94a00] [debug] chunk: plain text (out html: false)
[23:40:14.985266] [0x00007f007cb94a00] [warning] charset: not defined.
[23:40:14.985304] [0x00007f007cb94a00] [debug] ms: deconstruct
[23:40:14.985325] [0x00007f007cb94a00] [debug] chunk: deconstruct.
[23:40:14.985363] [0x00007f007cb94a00] [debug] cm: build..
[23:40:14.985406] [0x00007f007cb94a00] [debug] cm: finalize..
[23:40:14.985475] [0x00007f007cb94a00] [debug] same account: true
[23:40:14.985607] [0x00007f007cb94a00] [info] cm: wrote tmp file: /tmp/astroid-compose-uKm4By
[23:40:14.985630] [0x00007f007cb94a00] [info] msg: loading message from file: 
[23:40:14.985698] [0x00007f007cb94a00] [debug] chunk (1): content-type: text/plain
[23:40:14.985717] [0x00007f007cb94a00] [debug] chunk: preferred.
[23:40:14.985727] [0x00007f007cb94a00] [debug] chunk: is part (viewable: true, attachment: false) 
[23:40:14.985751] [0x00007f007cb94a00] [info] render: loading html..
[23:40:14.986009] [0x00007f007cb94a00] [info] tv: navigation action: 5
[23:40:14.986029] [0x00007f007cb94a00] [info] tv: navigating to: /home/hugo/.config/astroid/rcol8n9mgz81i5r7rb6fkovqbbeg1m156jova5e9j8c6h33u1osaxmbzhqylxgqv746tfjbxu0tt1v80ps19eyll6dz722tkcqejjs9m30mclnw8qy9jiz4e
[23:40:14.986068] [0x00007f007cb94a00] [debug] tv: on_load_changed: 0
[23:40:14.986183] [0x00007f007cb94a00] [debug] cm: deinitialized.
[23:40:14.986254] [0x00007f007cb94a00] [debug] em: ex: launching editor: emacsclient -q -c /home/hugo/.cache/astroid/1488321614.35142oc69b.hugo@local.fqdn
[23:40:14.989906] [0x00007f007cb94a00] [debug] em: set info (ready: false): Editing..
[23:40:15.007119] [0x00007f007cb94a00] [debug] tv: on_load_changed: 1
[23:40:15.016121] [0x00007f007cb94a00] [debug] tv: on_load_changed: 3
[23:40:15.016214] [0x00007f007cb94a00] [debug] tv: on_load_changed: 2
[23:40:15.016235] [0x00007f007cb94a00] [debug] tv: load finished.
[23:40:15.017912] [0x00007f007cb94a00] [debug] render: html loaded, building messages..
[23:40:15.017979] [0x00007f007cb94a00] [debug] tv: adding message: 1488321614.35142oc69b.hugo@local.fqdn
[23:40:15.018244] [0x00007f007cb94a00] [debug] gravatar: for: hugo@Emaildomain, uri: https://www.gravatar.com/avatar/19188dd148e4bb0163194085abd3d2a8?d=retro&s=48
[23:40:15.024179] [0x00007f007cb94a00] [debug] create message part: 1 (siblings: 0) (kids: 0) (attachment: false) (viewable: true) (mimetype: text/plain)
[23:40:15.024271] [0x00007f007cb94a00] [debug] create body part: 1
[23:40:15.024335] [0x00007f007cb94a00] [debug] chunk: body: part
[23:40:15.024356] [0x00007f007cb94a00] [debug] chunk: plain text (out html: true)
[23:40:15.024375] [0x00007f007cb94a00] [debug] enc: quoted-printable
[23:40:15.024399] [0x00007f007cb94a00] [debug] charset: utf-8
[23:40:15.024612] [0x00007f007cb94a00] [debug] tv: make preview..
[23:40:15.024635] [0x00007f007cb94a00] [debug] chunk: body: part
[23:40:15.024654] [0x00007f007cb94a00] [debug] chunk: plain text (out html: false)
[23:40:15.024673] [0x00007f007cb94a00] [debug] enc: quoted-printable
[23:40:15.024690] [0x00007f007cb94a00] [debug] charset: utf-8
[23:40:15.025520] [0x00007f007cb94a00] [info] tv: ready emitted.
[23:40:15.025567] [0x00007f007cb94a00] [debug] em: got tv ready.
[23:40:15.025582] [0x00007f007cb94a00] [debug] em: set info (ready: true): Editing..
[23:40:15.025602] [0x00007f007cb94a00] [debug] tv: set info: Editing..
[23:40:15.025684] [0x00007f007cb94a00] [debug] em: set warning (ready: true): 
[23:40:15.117586] [0x00007f007cb94a00] [warning] poll script:  Syncing Sent: IMAP -> Maildir
[23:40:15.118370] [0x00007f007cb94a00] [warning] poll script:  Copy message UID -1 (1/1) ampoliros.local:Sent -> ampoliros.remote
[23:40:15.180920] [0x00007f007cb94a00] [warning] poll script: Folder Spam [acc: ampoliros]:
[23:40:15.430721] [0x00007f007cb94a00] [warning] poll script:  Syncing Spam: IMAP -> Maildir
[23:40:15.434869] [0x00007f007cb94a00] [warning] poll script: Folder INBOX [acc: ampoliros]:
[23:40:15.486839] [0x00007f007cb94a00] [warning] poll script:  Copy message UID 2722 (1/1) ampoliros.remote:INBOX -> ampoliros.local
[23:40:15.486953] [0x00007f007cb94a00] [warning] poll script: Folder Spam [acc: ampoliros]:
[23:40:15.523887] [0x00007f007cb94a00] [warning] poll script:  Copy message UID -2 (1/2) ampoliros.local:Spam -> ampoliros.remote
[23:40:15.523972] [0x00007f007cb94a00] [warning] poll script: Folder INBOX [acc: ampoliros]:
[23:40:15.861159] [0x00007f007cb94a00] [warning] poll script:  Deleting 2 messages (2662,2681) in IMAP[INBOX]
[23:40:15.861243] [0x00007f007cb94a00] [warning] poll script:  Adding flag R to 1 messages on INBOX
[23:40:15.993076] [0x00007f007cb94a00] [warning] poll script: Folder Trash [acc: ampoliros]:
[23:40:17.120279] [0x00007f007cb94a00] [warning] poll script:  Syncing Trash: IMAP -> Maildir
[23:40:17.120384] [0x00007f007cb94a00] [warning] poll script: Folder Spam [acc: ampoliros]:
[23:40:17.896329] [0x00007f007cb94a00] [warning] poll script:  Copy message UID -1 (2/2) ampoliros.local:Spam -> ampoliros.remote
[23:40:17.896556] [0x00007f007cb94a00] [warning] poll script: Account sync ampoliros:
[23:40:18.027909] [0x00007f007cb94a00] [debug] poll script: Processed 4 total files in almost no time.
[23:40:18.505387] [0x00007f007cb94a00] [warning] poll script:  *** Finished account 'ampoliros' in 0:13
[23:40:18.505479] [0x00007f007cb94a00] [warning] poll script: INFO:afew.filters.SpamFilter.SpamFilter:Tagging spam messages
[23:40:18.507520] [0x00007f007cb94a00] [warning] poll script: INFO:afew.filters.ListMailsFilter.ListMailsFilter:Tagging mailing list posts
[23:40:18.508740] [0x00007f007cb94a00] [warning] poll script: INFO:afew.filters.ListMailsFilter.ListMailsFilter:Committing changes to 1 messages
[23:40:19.294641] [0x00007f007cb94a00] [warning] poll script: INFO:root:checking mails in 'ampoliros/INBOX'
[23:40:19.295528] [0x00007f007cb94a00] [warning] poll script: INFO:root:updating database
[23:40:19.341011] [0x00007f007cb94a00] [debug] poll script: Added 1 new message to the database. Detected 3 file renames.
[23:40:19.341285] [0x00007f007cb94a00] [debug] poll script: Processed 1 file in almost no time.
[23:40:19.376184] [0x00007f007cb94a00] [info] poll: done (time: 14.6288 s) (child status: 0)
[23:40:19.376273] [0x00007f007cb94a00] [info] db: open db read-only, waiting for lock..
[23:40:19.376288] [0x00007f007cb94a00] [debug] db: read-only got lock.
[23:40:19.376442] [0x00007f007cb94a00] [debug] db: open time: 0.169 ms.
[23:40:19.376464] [0x00007f007cb94a00] [debug] poll: revision after poll: 1093056
[23:40:19.385094] [0x00007f007cb94a00] [info] poll: 5 threads changed, updating..
[23:40:19.394749] [0x00007f007cb94a00] [info] actions: emitted updated and changed signal for thread: 0000000000023d60
[23:40:19.394810] [0x00007f007cb94a00] [info] ql (0): tag:inbox, got changed thread signal: 0000000000023d60
[23:40:19.394911] [0x00007f007cb94a00] [debug] db: checking if thread: 0000000000023d60 matches query: tag:inbox
[23:40:19.395095] [0x00007f007cb94a00] [debug] db: thread in query check: 0.189 ms.
[23:40:19.395123] [0x00007f007cb94a00] [debug] ql: updated: found thread in: 0.3 ms.
[23:40:19.395136] [0x00007f007cb94a00] [debug] ql: updated
[23:40:19.396009] [0x00007f007cb94a00] [debug] ql: refresh stats..
[23:40:19.396843] [0x00007f007cb94a00] [info] actions: emitted updated and changed signal for thread: 00000000000243b7
[23:40:19.396868] [0x00007f007cb94a00] [info] ql (0): tag:inbox, got changed thread signal: 00000000000243b7
[23:40:19.397328] [0x00007f007cb94a00] [debug] db: checking if thread: 00000000000243b7 matches query: tag:inbox
[23:40:19.397486] [0x00007f007cb94a00] [debug] db: thread in query check: 0.163 ms.
[23:40:19.397511] [0x00007f007cb94a00] [debug] ql: updated: did not find thread, time used: 0.633 ms.
[23:40:19.397523] [0x00007f007cb94a00] [debug] ql: new thread for query, adding..
[23:40:19.398050] [0x00007f007cb94a00] [debug] ql: refresh stats..
[23:40:19.398877] [0x00007f007cb94a00] [info] actions: emitted updated and changed signal for thread: 00000000000243b6
[23:40:19.398902] [0x00007f007cb94a00] [info] ql (0): tag:inbox, got changed thread signal: 00000000000243b6
[23:40:19.399344] [0x00007f007cb94a00] [debug] db: checking if thread: 00000000000243b6 matches query: tag:inbox
[23:40:19.399472] [0x00007f007cb94a00] [debug] db: thread in query check: 0.133 ms.
[23:40:19.399495] [0x00007f007cb94a00] [debug] ql: updated: did not find thread, time used: 0.582 ms.
[23:40:19.399703] [0x00007f007cb94a00] [info] actions: emitted updated and changed signal for thread: 00000000000243a4
[23:40:19.399725] [0x00007f007cb94a00] [info] ql (0): tag:inbox, got changed thread signal: 00000000000243a4
[23:40:19.400166] [0x00007f007cb94a00] [debug] db: checking if thread: 00000000000243a4 matches query: tag:inbox
[23:40:19.400292] [0x00007f007cb94a00] [debug] db: thread in query check: 0.131 ms.
[23:40:19.400314] [0x00007f007cb94a00] [debug] ql: updated: did not find thread, time used: 0.578 ms.
[23:40:19.400473] [0x00007f007cb94a00] [info] actions: emitted updated and changed signal for thread: 0000000000024396
[23:40:19.400495] [0x00007f007cb94a00] [info] ql (0): tag:inbox, got changed thread signal: 0000000000024396
[23:40:19.400930] [0x00007f007cb94a00] [debug] db: checking if thread: 0000000000024396 matches query: tag:inbox
[23:40:19.401054] [0x00007f007cb94a00] [debug] db: thread in query check: 0.129 ms.
[23:40:19.401076] [0x00007f007cb94a00] [debug] ql: updated: did not find thread, time used: 0.571 ms.
[23:40:19.401123] [0x00007f007cb94a00] [info] db: closing db.
[23:40:19.401265] [0x00007f007cb94a00] [debug] db: ro: waiting for lock to close..
[23:40:19.401282] [0x00007f007cb94a00] [debug] db: ro: closing..
[23:40:19.401326] [0x00007f007cb94a00] [info] poll: emitted poll state: false
[23:40:23.418413] [0x00007f007cb94a00] [debug] em: ex: file changed, updating preview..
[23:40:23.418581] [0x00007f007cb94a00] [debug] em: reading edited message..
[23:40:23.418661] [0x00007f007cb94a00] [debug] em: set warning (ready: true): 
[23:40:23.418994] [0x00007f007cb94a00] [debug] cm: initialize..
[23:40:23.419203] [0x00007f007cb94a00] [info] msg: loading message from file (mid supplied): /home/hugo/.cache/astroid/1488321614.35142oc69b.hugo@local.fqdn
[23:40:23.419660] [0x00007f007cb94a00] [debug] chunk (2): content-type: text/plain
[23:40:23.419787] [0x00007f007cb94a00] [debug] chunk: preferred.
[23:40:23.419853] [0x00007f007cb94a00] [debug] chunk: is part (viewable: true, attachment: false) 
[23:40:23.420109] [0x00007f007cb94a00] [debug] chunk: body: part
[23:40:23.420191] [0x00007f007cb94a00] [debug] chunk: plain text (out html: false)
[23:40:23.420277] [0x00007f007cb94a00] [warning] charset: not defined.
[23:40:23.420424] [0x00007f007cb94a00] [debug] ms: deconstruct
[23:40:23.420532] [0x00007f007cb94a00] [debug] chunk: deconstruct.
[23:40:23.420671] [0x00007f007cb94a00] [debug] cm: build..
[23:40:23.420846] [0x00007f007cb94a00] [debug] cm: finalize..
[23:40:23.421251] [0x00007f007cb94a00] [debug] same account: false
[23:40:23.421415] [0x00007f007cb94a00] [debug] got sig: false
[23:40:23.421497] [0x00007f007cb94a00] [debug] em: preparing message from fields..
[23:40:23.421571] [0x00007f007cb94a00] [error] em: preparing message while in read

(astroid:19434): glibmm-ERROR **: 
unhandled exception (type std::exception) in signal handler:
what: em: preparing message while in read

[1]    19434 trace trap (core dumped)  ./astroid
gauteh commented 7 years ago

Hugo Roy writes on februar 28, 2017 23:45:

↪ Gaute Hope / février 28, 2017 9:43:

Please test #293

It crashed when I modify the “From:” and save the buffer (does not crash if I don't modify the “From:” in emacs):

Hi, please try again with latest changes

hugoroy commented 7 years ago

↪ Gaute Hope / mars 2, 2017 12:13:

Hi, please try again with latest changes

I just tried. Here are the results:

  1. Writing a new mail, changing the from, editing the content, saving, quitting emacs: the mail content is lost;

  2. Writing a new mail, changing the from, saving, trying to edit the content: emacs asks if I really want to edit the buffer because the file changed on disk.

gauteh commented 7 years ago

hm, are you sure pulled the latest and compiled, you might have to do pull --force.

hugoroy commented 7 years ago

↪ Gaute Hope / mars 2, 2017 13:25:

hm, are you sure pulled the latest and compiled, you might have to do pull --force.

I pulled master, then checked oun in the 292-something branch, pulled again and "scons". Everything seemed to go fine. Did I miss something?

Note that the behaviour is different than previously, I don't crash :)

hugoroy commented 7 years ago
hugo@xps ~/.gitRepos/astroid (git)-[292-fix-external-from-change] % git pull origin 292-fix-external-from-change 
Depuis https://github.com/astroidmail/astroid
* branch            292-fix-external-from-change -> FETCH_HEAD
Déjà à jour.
hugo@xps ~/.gitRepos/astroid (git)-[292-fix-external-from-change] % git pull --force origin 292-fix-external-from-change
Depuis https://github.com/astroidmail/astroid
* branch            292-fix-external-from-change -> FETCH_HEAD
Déjà à jour.
hugo@xps ~/.gitRepos/astroid (git)-[292-fix-external-from-change] % scons
scons: Reading SConscript files ...
building version v0.7-51-g89583139 (git)..
debug flag enabled: True
Checking for pkg-config... (cached) yes
Checking for gtkmm-3.0 >= 3.10... (cached) yes
Checking for glibmm-2.4... (cached) yes
Checking for gmime-2.6 >= 2.6.18... (cached) yes
Checking for webkitgtk-3.0... (cached) yes
Checking for vte-2.91... (cached) yes
Checking for C library libsass... (cached) no
Checking for C library libsass... (cached) yes
Checking for gobject-introspection-1.0... (cached) yes
Checking for libpeas-1.0... (cached) yes
Checking for C library notmuch... (cached) yes
Checking for C function notmuch_database_get_revision..(cached) yes
Checking for C function notmuch_query_search_threads_st..(cached) yes
Checking for C function notmuch_query_count_threads_st..(cached) yes
Checking for C++ library boost_filesystem... (cached) yes
Checking for C++ library boost_system... (cached) yes
Checking for C++ library boost_program_options... (cached) yes
Checking for C++ library boost_log_setup... (cached) yes
Checking for C++ library boost_log... (cached) yes
Checking for C++ library boost_thread... (cached) yes
Checking for C++ library boost_date_time... (cached) yes
writing src/build_config.hh..

    debug   ..:  True
    release ..:  git
    version ..:  v0.7-51-g89583139
    profile ..:  False
    libsass ..:  True
    scss .....:  sassc ( use: False )
    plugins ..:  True
    terminal .:  True

scons: done reading SConscript files.
scons: Building targets ...
scons: `astroid' is up to date.
scons: done building targets.
gauteh commented 7 years ago

Hm, that looks right... do you have regular signature or encryption settings on by default for any of the involved accounts (original and changed to)?

hugoroy commented 7 years ago

↪ Gaute Hope / mars 2, 2017 13:35:

Hm, that looks right... do you have regular signature or encryption settings on by default for any of the involved accounts (original and changed to)?

Okay.... my bad. I was actually launching my regular astroid rather than the local build!

The 292-... branch version works, even with an account which has pgp signature enabled by default!

This looks completely resolved :^)

gauteh commented 7 years ago

Excellent!!